Skip to content

Make sure the project is built on Release mode & improve includes #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make sure the project is built on Release mode & improve includes #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4701b9b
Update CMakeLists.txt
3manifold Oct 7, 2025
ca9d44d
Remove redundant in pthread_backend.h
3manifold Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@ project(
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED TRUE)

IF (NOT CMAKE_BUILD_TYPE)
MESSAGE(STATUS "CMAKE_BUILD_TYPE IS EMPTY. ASSIGN: RELEASE")
SET(CMAKE_BUILD_TYPE RELEASE)
ENDIF ()

add_subdirectory(3rd)
add_subdirectory(csrc)

if(EXISTS ${CMAKE_SOURCE_DIR}/tests)
add_subdirectory(tests)
endif()
endif()
3 changes: 1 addition & 2 deletions include/pthread_backend.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include <stdexcept>
#include <sys/io.h>
#include <sys/uio.h>
#include <unistd.h>
#include <cstdlib>
Expand Down Expand Up @@ -59,4 +58,4 @@ class PthreadAsyncIO : public AsyncIO

void write_tensor(int fd, torch::Tensor t, unsigned long long offset, callback_t callback, std::optional<torch::Tensor> pinned);
void register_tasks(unsigned int num_tasks);
};
};