Skip to content

Commit 05cf73a

Browse files
coliffcoliff
authored
Merge branch 'beta' into feat/add-config-attribute-extends
2 parents a763b2e + 442fa56 commit 05cf73a

File tree

8 files changed

+163
-43
lines changed

8 files changed

+163
-43
lines changed

‎.github/ISSUE_TEMPLATE/CHANGE.md‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
---
2+
name: "\U0001F4DD Non-rule change request"
3+
about: Request a change that is not a bug fix, rule change, or new rule
4+
title: ''
5+
labels: enhancement, triage
6+
assignees: ''
7+
---
8+
9+
**The version of HTMLHint you are using.**
10+
11+
**The problem you want to solve.**
12+
13+
**Your take on the correct solution to problem.**
14+
15+
**Are you willing to submit a pull request to implement this change?**

‎.github/ISSUE_TEMPLATE/NEW_RULE.md‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
---
2+
name: "\U0001F680 New rule proposal"
3+
about: Propose a new rule to be added to HTMLHint
4+
title: ''
5+
labels: triage, feature request
6+
assignees: ''
7+
---
8+
9+
**Please describe what the rule should do:**
10+
11+
**What category of rule is this? (place an "X" next to just one item)**
12+
13+
[ ] Warns about a potential error (problem)
14+
[ ] Suggests an alternate way of doing something (suggestion)
15+
[ ] Other (please specify:)
16+
17+
**Provide 2-3 code examples that this rule will warn about:**
18+
19+
<!-- Put your code examples here -->
20+
21+
```html
22+
23+
```
24+
25+
**Are you willing to submit a pull request to implement this rule?**

‎.github/ISSUE_TEMPLATE/QUESTION.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
name: '⛔ Question'
3+
about: Please go to https://discord.com/invite/nJ6J9CP
4+
title: ''
5+
labels: discussion
6+
assignees: ''
7+
---
8+
9+
<!--
10+
Please do not use GitHub for asking questions. Instead,
11+
please visit our chatroom:
12+
13+
https://discord.com/invite/nJ6J9CP
14+
15+
Thanks in advance for helping us keep the issue tracker
16+
clean!
17+
-->

‎.github/ISSUE_TEMPLATE/RULE_CHANGE.md‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
---
2+
name: "\U0001F4DD Rule change request"
3+
about: Request a change to an existing rule
4+
title: ''
5+
labels: enhancement, triage
6+
assignees: ''
7+
---
8+
9+
**What rule do you want to change?**
10+
11+
**Does this change cause the rule to produce more or fewer warnings?**
12+
13+
**How will the change be implemented? (New option, new default behavior, etc.)?**
14+
15+
**Please provide some example code that this change will affect:**
16+
17+
<!-- Put your code examples here -->
18+
19+
```html
20+
21+
```
22+
23+
**What does the rule currently do for this code?**
24+
25+
**What will the rule do after it's changed?**
26+
27+
**Are you willing to submit a pull request to implement this change?**

‎.github/ISSUE_TEMPLATE/SECURITY.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
name: '⛔ Security issue'
3+
about: Report a security issue with HTMLHint
4+
title: ''
5+
labels: security
6+
assignees: ''
7+
---
8+
9+
**Tell us about the security issue**
10+
11+
**Are you willing to submit a pull request to fix this bug?**

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 35 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,47 @@
11
---
2-
name: Bug report
3-
about: Create a report to help us improve
2+
name: "\U0001F41E Bug report"
3+
about: Report an issue with HTMLHint or rules bundled with HTMLHint
4+
title: ''
5+
labels: bug, triage
6+
assignees: ''
47
---
58

6-
**Describe the bug**
7-
A clear and concise description of what the bug is.
9+
**Tell us about your environment**
810

9-
**To Reproduce**
10-
Steps to reproduce the behavior:
11+
- **HTMLHint Version:**
12+
- **Node Version:**
13+
- **npm Version:**
14+
- **os Version:**
1115

12-
1. Go to '...'
13-
2. Click on '....'
14-
3. Scroll down to '....'
15-
4. See error
16+
**Please show your full configuration:**
1617

17-
**Expected behavior**
18-
A clear and concise description of what you expected to happen.
18+
<details>
19+
<summary>Configuration</summary>
1920

20-
**Screenshots**
21-
If applicable, add screenshots to help explain your problem.
21+
<!-- Paste your .htmlhintrc configuration below: -->
2222

23-
**Desktop (please complete the following information):**
23+
```json
2424

25-
- OS: [e.g. iOS]
26-
- Browser [e.g. chrome, safari]
27-
- Version [e.g. 22]
25+
```
2826

29-
**Smartphone (please complete the following information):**
27+
</details>
3028

31-
- Device: [e.g. iPhone6]
32-
- OS: [e.g. iOS8.1]
33-
- Browser [e.g. stock browser, safari]
34-
- Version [e.g. 22]
29+
**What did you do? Please include the actual source code causing the issue, as well as the command that you used to run HTMLHint.**
3530

36-
**Additional context**
37-
Add any other context about the problem here.
31+
<!-- Paste the source code below: -->
32+
33+
```html
34+
35+
```
36+
37+
<!-- Paste the command you used to run HTMLHint: -->
38+
39+
```shell
40+
41+
```
42+
43+
**What did you expect to happen?**
44+
45+
**What actually happened? Please include the actual, raw output from HTMLHint.**
46+
47+
**Are you willing to submit a pull request to fix this bug?**

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 0 additions & 16 deletions
This file was deleted.

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,36 @@
1-
***Short description of what this resolves:***
1+
<!-- Thank you for contributing! -->
22

3+
#### Prerequisites checklist
34

4-
***Proposed changes:***
5+
- [ ] I have read the [contributing guidelines](https://github.com/htmlhint/HTMLHint/blob/master/CONTRIBUTING.md).
56

7+
#### What is the purpose of this pull request?
8+
9+
<!-- Choose one, remove the other items -->
10+
11+
<!-- Documentation update -->
12+
<!-- Bug fix -->
13+
<!-- New rule -->
14+
<!-- Changes an existing rule -->
15+
<!-- Add a CLI option -->
16+
<!-- Add something to the core -->
17+
<!-- Other, please explain: -->
18+
19+
#### This pull request is related to one or multiple issue?
20+
21+
<!-- closes #000 -->
22+
23+
#### What changes did you make?
24+
25+
26+
#### Is there anything you'd like reviewers to focus on?
27+
28+
29+
#### Please tick every checkbox you have done
30+
31+
- [ ] Tested my changes
32+
- [ ] Added/Changed tested in test directory
33+
- [ ] Added/Changed documentation
34+
- [ ] in code
35+
- [ ] in website
36+
- [ ] in json schema

0 commit comments

Comments
 (0)