Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

Corrected missing word "be" in the attr-value-double-quotes rule description.

Changes

  • test/cli/formatters/sarif.sarif: Updated markdown help text from "Attribute value must closed by double quotes" to "Attribute value must be closed by double quotes"
  • website/src/content/docs/rules/attr-value-double-quotes.mdx: Applied same correction to source documentation

The error appeared in both the SARIF test fixture and the rule's documentation page, affecting the generated SARIF output and user-facing docs.

Original prompt
Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"The text \"Attribute value must closed by double quotes\" is missing the word \"be\" - it should read \"Attribute value must be closed by double quotes.\"","fixFiles":[{"filePath":"test/cli/formatters/sarif.sarif","diff":"diff --git a/test/cli/formatters/sarif.sarif b/test/cli/formatters/sarif.sarif\n--- a/test/cli/formatters/sarif.sarif\n+++ b/test/cli/formatters/sarif.sarif\n@@ -15,7 +15,7 @@\n               \"helpUri\": \"https://htmlhint.com/rules/attr-value-double-quotes\",\n               \"help\": {\n                 \"text\": \"Attribute values must be in double quotes.\",\n-                \"markdown\": \"\\nAttribute value must closed by double quotes.\\n\\nLevel: Error\\n\\n## Config value\\n\\n- `true`: enable rule\\n- `false`: disable rule\\n\\n### The following patterns are **not** considered rule violations\\n\\n```html\\n`<a href=\\\"\\\" title=\\\"abc\\\">``</a>`\\n```\\n\\n### The following pattern is considered a rule violation:\\n\\n```html\\n`<a href='' title='abc'>``</a>`\\n```\"\n+                \"markdown\": \"\\nAttribute value must be closed by double quotes.\\n\\nLevel: Error\\n\\n## Config value\\n\\n- `true`: enable rule\\n- `false`: disable rule\\n\\n### The following patterns are **not** considered rule violations\\n\\n```html\\n`<a href=\\\"\\\" title=\\\"abc\\\">``</a>`\\n```\\n\\n### The following pattern is considered a rule violation:\\n\\n```html\\n`<a href='' title='abc'>``</a>`\\n```\"\n               }\n             },\n             {\n"}]}]

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 4, 2025
Co-authored-by: coliff <1212885+coliff@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

Deploying htmlhint with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb1f366
Status: ✅  Deploy successful!
Preview URL: https://e44af5e6.htmlhint.pages.dev
Branch Preview URL: https://copilot-fix-attribute-value.htmlhint.pages.dev

View logs

Copilot AI changed the title [WIP] Fix missing word in attribute value error message Fix grammatical error in attr-value-double-quotes rule documentation Nov 4, 2025
Copilot AI requested a review from coliff November 4, 2025 01:22
Copilot finished work on behalf of coliff November 4, 2025 01:22
@coliff coliff marked this pull request as ready for review November 4, 2025 01:23
@coliff coliff requested a review from thedaviddias as a code owner November 4, 2025 01:23
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (95e6a13) to head (fb1f366).
⚠️ Report is 161 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1755      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87d7a7...fb1f366. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coliff coliff merged commit f4bc27f into main Nov 4, 2025
25 checks passed
@coliff coliff deleted the copilot/fix-attribute-value-quote-message branch November 4, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants