Handle failed server stops (taskkill+clean stop race)

pimterry · pimterry · commit 0568f7955955 · 2022-11-02T14:00:35.000+01:00
diff --git a/src/stop-server.ts b/src/stop-server.ts
@@ -27,7 +27,8 @@ export async function stopServer(proc: ChildProcess.ChildProcess, token: string)
         await delay(100);
 
         if (Date.now() >= deadline) {
-            await hardKill(proc);
+            await hardKill(proc)
+                .catch(console.warn); // Not much we can do if this fails really
             break;
         }
     } while (isRunning(proc.pid!))

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,8 @@ export async function stopServer(proc: ChildProcess.ChildProcess, token: string)`
`27`	`27`	`await delay(100);`
`28`	`28`
`29`	`29`	`if (Date.now() >= deadline) {`
`30`		`- await hardKill(proc);`
	`30`	`+ await hardKill(proc)`
	`31`	`+ .catch(console.warn); // Not much we can do if this fails really`
`31`	`32`	`break;`
`32`	`33`	`}`
`33`	`34`	`} while (isRunning(proc.pid!))`