Tweak error logging around updates

We see quite a few 'cannot read message/statusCode' errors, with no
clear cause, and EACCES errors we can do nothing about. This should
explain the former and quiet the latter.

Author: pimterry

src/error-tracking.ts

@@ -3,6 +3,8 @@ import { randomUUID } from 'crypto';
 import * as child_process from 'child_process';
 import * as Sentry from '@sentry/node';
 import { RewriteFrames } from '@sentry/integrations';
+import { ErrorLike } from '@httptoolkit/util';
+
 import { IS_PROD_BUILD } from './constants';
 
 let sentryInitialized = false;
@@ -129,14 +131,22 @@ export function addBreadcrumb(message: string, data: Sentry.Breadcrumb) {
     Sentry.addBreadcrumb(Object.assign({ message }, data));
 }
 
-export function logError(error: Error | string | unknown): undefined | Promise<void> {
+export function logError(error: Error | string | unknown, extra?: { cause?: ErrorLike }): undefined | Promise<void> {
     console.warn(error);
     if (!sentryInitialized) return;
 
+    // If we pass a cause, simplify/anonymize the cause message too if present:
+    if (extra?.cause) {
+        extra.cause = {
+            ...extra.cause,
+            message: extra.cause.message ? simplifyErrorMessages(extra.cause.message) : undefined
+        };
+    }
+
     if (typeof error === 'string') {
-        Sentry.captureMessage(error);
+        Sentry.captureMessage(error, { extra });
     } else {
-        Sentry.captureException(error);
+        Sentry.captureException(error, { extra });
     }
 
     return Sentry.flush(500).then((sentSuccessfully) => {

src/index.ts

@@ -245,6 +245,13 @@ export async function runHTK(options: {
                         return delay(1000 * 60 * 60 * 6, { unref: true });
                     }
 
+                    if (error.code === 'EACCES') {
+                        // We're running the server without write access to the update directory.
+                        // Weird, but it happens and there's nothing we can do - ignore it.
+                        console.log(`Update check failed: ${error.message}`);
+                        return;
+                    }
+
                     // Report any HTTP response errors cleanly & explicitly:
                     if (error.statusCode) {
                         let url: string | undefined;
@@ -263,7 +270,7 @@ export async function runHTK(options: {
                 }
 
                 console.log(error.message);
-                logError(`Failed to check for updates: ${error.message}`);
+                logError(`Failed to check for updates: ${error.message}`, { cause: error });
             })
         );
     });