fix: settings page in dark mode#782
Closed
KartikGS wants to merge 19 commits intohuggingface:mainfrom
Closed
Conversation
Collaborator
|
you can run the formatter locally by: |
KartikGS
force-pushed
the
front/setting_page_theme
branch
from
28e325f to
851a7a4
Compare
KartikGS
force-pushed
the
front/setting_page_theme
branch
from
851a7a4 to
9737ef1
Compare
Contributor
|
cc @gary149 maybe, to take a look? I think it'd be nice to have dark mode settings for sure |
…ge.svelte line 126
Collaborator
|
Great job! I've made some small fixes KartikGS#1 Alos, could you add the darkmode to newly added ReportModal ? |
…ont/setting_page_theme
[Assistants Settings] Small fixes in darkmode
…S/chat-ui into front/setting_page_theme
…S/chat-ui into front/setting_page_theme
Contributor
Author
|
DisclaimerModal, LoginModal and SystemPromptModal don't have darkmode either. |
Collaborator
we can handle in a separate PR |
Collaborator
|
One last remaining task on assistants settings darkmode is: "letter thumbnails" could benefit from darkmode as well. They should have darker bg & lighter letter on darkmode
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #746
dark theme in settings page
