Skip to content

Update model-libraries.ts for depthanything-ac #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghost233lism
Copy link

No description provided.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ghost233lism , thanks for your PR :) I've reviewed it and it's almost ready to merge. Can you make sure to add library_name: depthanything-ac to your model card metadata in https://huggingface.co/ghost233lism/DepthAnything-AC/blob/main/README.md? This will make it appear at https://huggingface.co/models?other=depthanything-ac for better discoverability.

@@ -266,6 +266,14 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
snippets: snippets.describe_anything,
filter: false,
},
"depthanything-ac": {
prettyLabel: "DepthAnything-AC",
repoName: "DepthAnythingAC",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repoName: "DepthAnythingAC",
repoName: "DepthAnything-AC",

let's keep same as "prettyLabel"

prettyLabel: "DepthAnything-AC",
repoName: "DepthAnythingAC",
repoUrl: "https://github.com/HVision-NKU/DepthAnythingAC",
snippets: snippets.DepthAnythingAC,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
snippets: snippets.DepthAnythingAC,

snippet doesn't seem to be defined for that library

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the model is fine-tuned from DepthAnything V2, then is it really necessary to add deptahanything-ac as a new library? If we assign library_name: depth-anything-v2, like here, would it just work out of the box? If so, I'd recommend doing that to reduce friction, and get usage snippets for free.

In addition, I'd recommend converting the model to transformers format and push it as a new repo. This way, it can be used directly from a transformers pipeline, which would also reduce friction and increase visibility. For example, the transformers version of depth-anything-v2 small had > 400K downloads in the last month, whereas downloads for the original library were ~10K.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants