fix: update pre-commit configuration and mypy settings

add args: --follow-imports=silent to pass error which have no relationship with src/lerobot/configs

Author: tetsugo02

.pre-commit-config.yaml

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 default_language_version:
-    python: python3.10
+  python: python3.10
 
 exclude: "tests/artifacts/.*\\.safetensors$"
 
@@ -24,12 +24,12 @@ repos:
       - id: check-useless-excludes
       - id: check-hooks-apply
 
-   ##### General Code Quality & Formatting #####
+    ##### General Code Quality & Formatting #####
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v5.0.0
     hooks:
       - id: check-added-large-files
-        args: ['--maxkb=1024']
+        args: ["--maxkb=1024"]
       - id: debug-statements
       - id: check-merge-conflict
       - id: check-case-conflict
@@ -54,7 +54,7 @@ repos:
   - repo: https://github.com/asottile/pyupgrade
     rev: v3.20.0
     hooks:
-    -   id: pyupgrade
+      - id: pyupgrade
         args: [--py310-plus]
 
   ##### Markdown Quality #####
@@ -80,18 +80,20 @@ repos:
   - repo: https://github.com/PyCQA/bandit
     rev: 1.8.6
     hooks:
-    - id: bandit
-      args: ["-c", "pyproject.toml"]
-      additional_dependencies: ["bandit[toml]"]
+      - id: bandit
+        args: ["-c", "pyproject.toml"]
+        additional_dependencies: ["bandit[toml]"]
 
   # TODO(Steven): Uncomment when ready to use
   ##### Static Analysis & Typing #####
-  # - repo: https://github.com/pre-commit/mirrors-mypy
-  #   rev: v1.16.0
-  #   hooks:
-  #     - id: mypy
-  #       args: [--python-version=3.10]
-
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.16.0
+    hooks:
+      - id: mypy
+        args: [--python-version=3.10, --follow-imports=silent]
+        files: ^src/lerobot/configs/
+        additional_dependencies:
+          ["numpy", "torch", "huggingface_hub", "draccus"]
   ##### Docstring Checks #####
   # - repo: https://github.com/akaihola/darglint2
   #   rev: v1.8.2

pyproject.toml

@@ -257,8 +257,8 @@ default.extend-ignore-identifiers-re = [
 # color = true
 # paths = ["src/lerobot"]
 
-# [tool.mypy]
-# python_version = "3.10"
-# warn_return_any = true
-# warn_unused_configs = true
-# ignore_missing_imports = false
+[tool.mypy]
+python_version = "3.10"
+warn_return_any = true
+warn_unused_configs = true
+ignore_missing_imports = false

src/lerobot/configs/policies.py

@@ -63,7 +63,7 @@ class PreTrainedConfig(draccus.ChoiceRegistry, HubMixin, abc.ABC):
     # automatic gradient scaling is used.
     use_amp: bool = False
 
-    push_to_hub: bool = True  # type: ignore[assignment]
+    push_to_hub: bool = True  # type: ignore[assignment] # TODO: use a different name to avoid override
     repo_id: str | None = None
 
     # Upload on private repository on the Hugging Face hub.
@@ -196,6 +196,9 @@ def from_pretrained(
         if config_file is None:
             raise FileNotFoundError(f"{CONFIG_NAME} not found in {model_id}")
 
+        if config_file is None:
+            raise FileNotFoundError(f"{CONFIG_NAME} not found in {model_id}")
+
         with open(config_file) as f:
             config = json.load(f)
 

src/lerobot/configs/train.py

@@ -188,4 +188,5 @@ def from_pretrained(
 @dataclass(kw_only=True)
 class TrainRLServerPipelineConfig(TrainPipelineConfig):
     # NOTE: In RL, we don't need an offline dataset
+    # TODO: Make `TrainPipelineConfig.dataset` optional
     dataset: DatasetConfig | None = None  # type: ignore[assignment] # because the parent class has made it's type non-optional