TST FIX Failing AutoAWQ test with torch 2.8 #2752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a failing AWQ test since torch 2.6 which is marked as xfail for torch=2.7. However, now torch 2.8 is out and the test is still failing. Therefore, the xfail now checks for torch>=2.7. As AWQ is no longer being maintained, we should expect this situation to deteriorate over time and eventually we'll have to remove it. But for the time being, it still appears to mostly work, so I suggest we leave it as is.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a failing AWQ test since torch 2.6 which is marked as
xfailfor torch=2.7 (see #2529). However, now torch 2.8 is out and the test is still failing. Therefore, the xfail now checks for torch>=2.7.As AWQ is no longer being maintained, we should expect this situation to deteriorate over time and eventually we'll have to remove it. But for the time being, it still appears to mostly work, so I suggest we leave it as is.
Since this is a GPU test, the PR CI won't cover it, but I tested it locally and the test is correctly xfailing.