Skip to content

Updated model card for mbart and mbart50 #37619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2025

Conversation

Vishesh-Mistry
Copy link
Contributor

@Vishesh-Mistry Vishesh-Mistry commented Apr 18, 2025

What does this PR do?

Addresses #36979 so that the documentation for mbart and mbart50 align with the standardized format for all model cards.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu, please let me know about any changes that may be required.

@github-actions github-actions bot marked this pull request as draft April 18, 2025 17:47
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@Vishesh-Mistry Vishesh-Mistry marked this pull request as ready for review April 18, 2025 17:52
@github-actions github-actions bot requested a review from stevhliu April 18, 2025 17:52
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Vishesh-Mistry Vishesh-Mistry requested a review from stevhliu April 19, 2025 17:15
Copy link
Contributor Author

@Vishesh-Mistry Vishesh-Mistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes have been addressed except the one regarding command-line usage. Let me know if you'd like me to include that as well

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few more changes and we should be ready to merge! 🤗

encoded_ar = tokenizer(article_ar, return_tensors="pt")
generated_tokens = model.generate(**encoded_ar, forced_bos_token_id=tokenizer.lang_code_to_id["en_XX"])
tokenizer.batch_decode(generated_tokens, skip_special_tokens=True)
```

## Documentation resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove this section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed these lines of code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I wasn't clear! The code example is fine the way it was before, but we can remove the ## Documentation resources section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have made the said changes

@Vishesh-Mistry
Copy link
Contributor Author

I have made all the said changes, please let me know if there are any other changes.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu force-pushed the update-mbart-model-card branch from 19837a9 to e7cf39e Compare April 22, 2025 19:04
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤗

@stevhliu stevhliu merged commit 1d9743e into huggingface:main Apr 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants