Skip to content

fix performance issue in convert_ids_to_tokens #37773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

martin-harmonic
Copy link
Contributor

No description provided.

@github-actions github-actions bot marked this pull request as draft April 24, 2025 23:39
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@martin-harmonic martin-harmonic marked this pull request as ready for review April 24, 2025 23:39
@github-actions github-actions bot requested a review from ArthurZucker April 24, 2025 23:39
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good! In most cases the performance impact should be negligible, but there are some models with several thousand special IDs.

@Rocketknight1
Copy link
Member

cc @itazap for tokenizers - it's simple enough and shouldn't have side effects, so feel free to merge if you're happy with it too

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@itazap
Copy link
Collaborator

itazap commented Apr 25, 2025

Looks good to me! thanks! 😊

@itazap itazap merged commit 6ce675e into huggingface:main Apr 25, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants