Skip to content

enable internvl UTs on XPU #37779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2025
Merged

enable internvl UTs on XPU #37779

merged 7 commits into from
Apr 30, 2025

Conversation

yao-matrix
Copy link
Contributor

@yao-matrix yao-matrix commented Apr 25, 2025

pytest -rA tests/models/internvl/test_modeling_internvl.py

137 cases PASSED, 4 failed cases are same as CUDA, will investigate in separate efforts.

FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_embeddings_untied_with_deepspeed
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_embeddings_untied_with_deepspeed_multi_gpu
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_tokens_embeddings_with_deepspeed
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_tokens_embeddings_with_deepspeed_multi_gpu

Signed-off-by: YAO Matrix <matrix.yao@intel.com>
@github-actions github-actions bot marked this pull request as draft April 25, 2025 07:15
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@yao-matrix
Copy link
Contributor Author

@ydshieh , pls help review, thx

@yao-matrix yao-matrix marked this pull request as ready for review April 25, 2025 07:17
@github-actions github-actions bot requested a review from ydshieh April 25, 2025 07:18
@Rocketknight1
Copy link
Member

cc @IlyasMoutawwakil

Signed-off-by: YAO Matrix <matrix.yao@intel.com>
@yao-matrix
Copy link
Contributor Author

@ydshieh @IlyasMoutawwakil , could you help review again? thx

Copy link
Member

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Only thing I'm a bit opinionated about is the use of "require_deterministic_for_xpu" because it behaves differently than other "require_xxx". We can probably try getting rid of it if ever the problem with "warn_only=True" was fixed ? #30774 (comment)

@yao-matrix
Copy link
Contributor Author

LGTM ! Only thing I'm a bit opinionated about is the use of "require_deterministic_for_xpu" because it behaves differently than other "require_xxx". We can probably try getting rid of it if every the problem with "warn_only=True" was fixed ? #30774 (comment)

it's a new info for me, let me go back to check with our pytorch team, and if OK, i will make update. And at the same time, we are working w/ our pytorch team to root cause this difference btw xpu and cuda.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Only 2 nits regarding formatting 🙏

Signed-off-by: Yao Matrix <matrix.yao@intel.com>
@yao-matrix
Copy link
Contributor Author

Thank you. Only 2 nits regarding formatting 🙏

@ydshieh thx, done per comments.

@ydshieh ydshieh merged commit 34f26e2 into huggingface:main Apr 30, 2025
18 checks passed
@yao-matrix yao-matrix deleted the internvl-xpu branch May 5, 2025 22:36
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* enable internvl UTs on XPU

Signed-off-by: YAO Matrix <matrix.yao@intel.com>

* fix style

Signed-off-by: YAO Matrix <matrix.yao@intel.com>

* fix style per comments

Signed-off-by: Yao Matrix <matrix.yao@intel.com>

---------

Signed-off-by: YAO Matrix <matrix.yao@intel.com>
Signed-off-by: Yao Matrix <matrix.yao@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants