enable internvl UTs on XPU #37779
Open
enable internvl UTs on XPU #37779
+101
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YAO Matrix <matrix.yao@intel.com>
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
@ydshieh , pls help review, thx |
| @@ -3887,8 +3885,8 @@ def test_sdpa_can_compile_dynamic(self): | |||
| self.skipTest(reason="This test requires an NVIDIA GPU with compute capability >= 8.0") | |||
| elif device_type == "rocm" and major < 9: | |||
| self.skipTest(reason="This test requires an AMD GPU with compute capability >= 9.0") | |||
| else: | |||
| self.skipTest(reason="This test requires a Nvidia or AMD GPU") | |||
| elif device_type not in ["cuda", "rocm", "xpu"]: | |||
There was a problem hiding this comment.
there's no device type "rocm"
| ("xpu", 3): 'user\n\nWhat are the differences between these two images?\nassistant\nThe images show the Statue of Liberty and the Golden Gate Bridge from different angles. Here are the differences:\n\n1. **Foreground', | ||
| ("cuda", 7): 'user\n\nWhat are the differences between these two images?\nassistant\nThe images show the Statue of Liberty and the Golden Gate Bridge from different angles. Here are the differences:\n\n1. **Angle', | ||
| } | ||
| ) # fmt: skip |
There was a problem hiding this comment.
why is # fmt: skip needed here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest -rA tests/models/internvl/test_modeling_internvl.py137 cases PASSED, 4 failed cases are same as CUDA, will investigate in separate efforts.
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_embeddings_untied_with_deepspeed
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_embeddings_untied_with_deepspeed_multi_gpu
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_tokens_embeddings_with_deepspeed
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_tokens_embeddings_with_deepspeed_multi_gpu