Skip to content

Conversation

@eustlb
Copy link
Contributor

@eustlb eustlb commented Nov 5, 2025

What does this PR do?

Lots of stuff to clean on Xcodec integration to reach the source of truth expected quality, mainly:

  1. Stuff could have been simplified a lot, the current integration is mainly a dump from the original codebase, and modular should have been used!
  2. The semantic decoder is instantiated but not used since we do not support training (and same for it's proj layer), adding dead weight to the model. Either we use it and enable training, either we remove it. No big interest in supporting training for now → let's remove
  3. The two passes on the encoder only to get the ouput shape causes mem spikes, it is uncessary!

Warning

This PR is breaking. TODO: let's see how to reduce the arm for users...

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: dac, xcodec

@eustlb eustlb changed the title [WIP] Clean xcodec 🧼 [WIP] 🚨 clean xcodec 🧼 Nov 5, 2025
@eustlb eustlb mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant