Fix base model prefix in VLMs #42059
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere2_vision, florence2, gemma3n, lfm2_vl, qwen3_vl, qwen3_vl_moe |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
approved these changes
Nov 6, 2025
Contributor
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
Should make things easier 😁
Comment on lines
+93
to
+95
| class Cohere2VisionPreTrainedModel(AyaVisionPreTrainedModel): | ||
| base_model_prefix = "model" | ||
|
|
Contributor
There was a problem hiding this comment.
we don't need to add it to all ? or maybe modular did it already
Member
Author
There was a problem hiding this comment.
you mean all VLM models? Not really, other VLMs have a conversion-mapping which is not compatible with base prefix. I opened another PR to make it compatible but waiting for core maintainers review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fiexes #41814. The incorrect prefix is throwing errors when loadiing a base model from checkpoint
It was a bad copy from llava, where the prefix is empty string to support BC with old-style checkpoints
Update: just realized I had a PR already in #41589 😅 which solves this issue + adds new functionality