From c98ea02777d52d9da0b006a4e1599ba2f246f503 Mon Sep 17 00:00:00 2001
From: AMindToThink <61801493+AMindToThink@users.noreply.github.com>
Date: Tue, 15 Apr 2025 12:58:07 -0500
Subject: [PATCH] value_model can't be None, so it shouldn't be Optional or
 have default None

---
 trl/trainer/ppo_trainer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trl/trainer/ppo_trainer.py b/trl/trainer/ppo_trainer.py
index 54b62394a8..885757767b 100644
--- a/trl/trainer/ppo_trainer.py
+++ b/trl/trainer/ppo_trainer.py
@@ -107,7 +107,7 @@ def __init__(
         ref_model: Optional[nn.Module],
         reward_model: nn.Module,
         train_dataset: Dataset,
-        value_model: Optional[nn.Module] = None,
+        value_model: nn.Module,
         data_collator: Optional[DataCollatorWithPadding] = None,
         eval_dataset: Optional[Union[Dataset, dict[str, Dataset]]] = None,
         # less commonly used