-
-
Notifications
You must be signed in to change notification settings - Fork 789
Add support for virtualenv #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ValekoZ
wants to merge
12
commits into
main
Choose a base branch
from
virtualenv_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
65330a7
Add support for virtualenv
ValekoZ f5f1bc5
Fix error when no gef.virtualenv_path is provided
ValekoZ 7c32602
Move activate_script_path
ValekoZ 7e97732
Add tests
ValekoZ 47739ee
fix https://github.com/hugsy/gef/pull/1119\#discussion_r1632361496
ValekoZ d321f69
fix https://github.com/hugsy/gef/pull/1119\#discussion_r1632361672
ValekoZ f1b62a6
fix https://github.com/hugsy/gef/pull/1119\#discussion_r1632362067
ValekoZ bf5cedc
fix nit before grazfather ask us :P
ValekoZ 2676b97
fix https://github.com/hugsy/gef/pull/1119\#discussion_r1632363581
ValekoZ f3f20f1
fix https://github.com/hugsy/gef/pull/1119\#discussion_r1632363581
ValekoZ 1132170
fix https://github.com/hugsy/gef/pull/1119\#discussion_r1632362067
ValekoZ 10a0fb7
fix https://github.com/hugsy/gef/pull/1119\#discussion_r1632363800
ValekoZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
""" | ||
virtualenv config test module | ||
""" | ||
|
||
from tests.base import RemoteGefUnitTestGeneric | ||
from os import system | ||
from tempfile import mktemp | ||
|
||
|
||
class VirtualenvConfig(RemoteGefUnitTestGeneric): | ||
"""virtualenv config test module""" | ||
|
||
def setUp(self) -> None: | ||
venv_path = mktemp() | ||
system(f"virtualenv {venv_path}") | ||
system(f"{venv_path}/bin/pip install numpy") | ||
|
||
self.venv_path = venv_path | ||
|
||
return super().setUp() | ||
|
||
def test_conf_venv(self): | ||
gdb = self._gdb | ||
gdb.execute(f"gef config gef.virtualenv_path {self.venv_path}") | ||
|
||
res = gdb.execute("pi __import__('numpy').test()", to_string=True) | ||
assert "NumPy version" in res |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this makes sense as a method here