-
-
Notifications
You must be signed in to change notification settings - Fork 73
Use NIOFileSystem #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
adam-fowler
wants to merge
4
commits into
main
Choose a base branch
from
nio-file-system
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use NIOFileSystem #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Pull request no significant performance differences ✅ SummaryNew baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Full Benchmark ComparisonComparing results between 'main' and 'pull_request'
RouterRouter:Echo metricsMalloc (total): results within specified thresholds, fold down for details.
Router:GET metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
Router:PUT metricsMalloc (total): results within specified thresholds, fold down for details.
Router:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
RouterBuilder:Middleware metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:LongPaths metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Parameters metricsMalloc (total): results within specified thresholds, fold down for details.
TrieRouter:Routing metricsMalloc (total): results within specified thresholds, fold down for details.
|
Joannis
approved these changes
Jan 15, 2025
eaf04aa
to
05ed006
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
- Coverage 83.69% 83.58% -0.12%
==========================================
Files 117 117
Lines 7650 7625 -25
==========================================
- Hits 6403 6373 -30
- Misses 1247 1252 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set this as a draft for the moment as while NonBlockingFileIO has been deprecated, NIOFileSystem still has an under bar prefix which indicates it has an unstable API.