Skip to content

Conversation

adam-fowler
Copy link
Member

I've set this as a draft for the moment as while NonBlockingFileIO has been deprecated, NIOFileSystem still has an under bar prefix which indicates it has an unstable API.

@adam-fowler adam-fowler requested a review from Joannis as a code owner January 13, 2025 17:09
@adam-fowler adam-fowler marked this pull request as draft January 13, 2025 17:12
Copy link

github-actions bot commented Jan 13, 2025

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '55f8eafc4bbf' with 4 'x86_64' processors with 15 GB memory, running:
#25-Ubuntu SMP Wed Jan 15 20:45:09 UTC 2025

Router

Router:Echo metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 869 869 869 869 869 869 869 1013
pull_request 869 869 869 869 869 869 869 1013
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Router:GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 568 568 568 568 568 568 568 2746
pull_request 568 568 568 568 568 568 568 2717
Δ 0 0 0 0 0 0 0 -29
Improvement % 0 0 0 0 0 0 0 -29

Router:Middleware metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 474 474 474 474 474 474 474 2681
pull_request 474 474 474 474 474 474 474 2710
Δ 0 0 0 0 0 0 0 29
Improvement % 0 0 0 0 0 0 0 29

Router:PUT metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 1371 1371 1371 1371 1371 1371 1371 771
pull_request 1371 1371 1371 1371 1371 1371 1371 775
Δ 0 0 0 0 0 0 0 4
Improvement % 0 0 0 0 0 0 0 4

Router:Parameters metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 818 818 818 818 818 818 818 2295
pull_request 818 818 818 818 818 818 818 2318
Δ 0 0 0 0 0 0 0 23
Improvement % 0 0 0 0 0 0 0 23

RouterBuilder:Middleware metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 472 472 472 472 472 472 472 2745
pull_request 472 472 472 472 472 472 472 2769
Δ 0 0 0 0 0 0 0 24
Improvement % 0 0 0 0 0 0 0 24

TrieRouter:LongPaths metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 15 15 15 15 15 15 15 239
pull_request 15 15 15 15 15 15 15 250
Δ 0 0 0 0 0 0 0 11
Improvement % 0 0 0 0 0 0 0 11

TrieRouter:Parameters metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 27 27 27 27 27 27 27 182
pull_request 27 27 27 27 27 27 27 186
Δ 0 0 0 0 0 0 0 4
Improvement % 0 0 0 0 0 0 0 4

TrieRouter:Routing metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 23 23 23 23 23 23 23 227
pull_request 23 23 23 23 23 23 23 231
Δ 0 0 0 0 0 0 0 4
Improvement % 0 0 0 0 0 0 0 4

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (de68f8a) to head (05ed006).

Files with missing lines Patch % Lines
Sources/Hummingbird/Files/FileIO.swift 79.16% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   83.69%   83.58%   -0.12%     
==========================================
  Files         117      117              
  Lines        7650     7625      -25     
==========================================
- Hits         6403     6373      -30     
- Misses       1247     1252       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants