Apply Dawid suggestions

Author: rafal-gorecki

mecanum_drive_controller/CMakeLists.txt

@@ -11,7 +11,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  add_compile_options(-Wall -Wextra)
+  add_compile_options(-Wall -Wextra -Wpedantic -Wshadow -Wold-style-cast)
 endif()
 
 set(THIS_PACKAGE_INCLUDE_DEPENDS
@@ -44,7 +44,6 @@ generate_parameter_library(
 
 add_library(mecanum_drive_controller SHARED src/mecanum_drive_controller.cpp
                                             src/odometry.cpp)
-target_compile_features(mecanum_drive_controller PUBLIC cxx_std_17)
 target_include_directories(
   mecanum_drive_controller
   PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
@@ -57,6 +56,8 @@ ament_target_dependencies(mecanum_drive_controller PUBLIC
 pluginlib_export_plugin_description_file(controller_interface
                                          mecanum_drive_plugin.xml)
 
+install(DIRECTORY include/ DESTINATION include/mecanum_drive_controller)
+
 install(
   TARGETS mecanum_drive_controller mecanum_drive_controller_parameters
   EXPORT export_mecanum_drive_controller

mecanum_drive_controller/src/mecanum_drive_controller_parameter.yaml

@@ -2,18 +2,34 @@ mecanum_drive_controller:
   front_left_wheel_name: {
     type: string,
     description: "Link name of the front left side wheel",
+    read_only: true,
+    validation: {
+      not_empty<>: null,
+    }
   }
   front_right_wheel_name: {
     type: string,
     description: "Link name of the front right side wheel",
+    read_only: true,
+    validation: {
+      not_empty<>: null,
+    }
   }
   rear_left_wheel_name: {
     type: string,
     description: "Link name of the rear left side wheel",
+    read_only: true,
+    validation: {
+      not_empty<>: null,
+    }
   }
   rear_right_wheel_name: {
     type: string,
     description: "Link name of the rear right side wheel",
+    read_only: true,
+    validation: {
+      not_empty<>: null,
+    }
   }
   wheel_separation_x: {
     type: double,