Skip to content

Conversation

KmakD
Copy link

@KmakD KmakD commented May 9, 2025

To be tested

  • changed get_value() -> get_optional().value()
  • added value_set_error
  • changed realtime_tools::RealtimeBox -> realtime_tools::RealtimeBuffer
  • Added standard code formatting - that's why PR looks so big

@KmakD KmakD marked this pull request as ready for review May 12, 2025 07:22
@rafal-gorecki rafal-gorecki self-requested a review May 12, 2025 13:40
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I would stay with ros2_control formatting clang setting. In future if we would like to update repo there will be less changes.
  2. We can also use the same pre-commit as ros2-control?

@KmakD
Copy link
Author

KmakD commented May 12, 2025

This is not a fork of ros2_controllers so I don't see a point in switching from Husarion standard formatting. Beside, the implementation for mecanum in ros2_controllers is way different from this one and I don't think will ever end up updating this to match ros2 control.

@rafal-gorecki rafal-gorecki merged commit ff2b156 into jazzy May 13, 2025
1 check passed
@rafal-gorecki rafal-gorecki deleted the update-mecanum-controller branch May 13, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants