fix(commands): /fly properly toggles (#610)

Update the fly command to toggle flying state instead of only enabling
it.
Add proper component initialization for the Flight component:
- Track flight state in Flight component
- Register Flight component with meta for UI visibility
- Automatically add Flight component to new Players
- Update packet flags based on current flight state
- Fixes #607

---------

Co-authored-by: Andrew Gazelka <andrew.gazelka@gmail.com>

Author: Kumpelinus

crates/hyperion-clap/src/lib.rs

@@ -26,7 +26,11 @@ use valence_protocol::{
 pub trait MinecraftCommand: Parser + CommandPermission {
     fn execute(self, world: &World, caller: Entity);
 
+    fn pre_register(_world: &World) {}
+
     fn register(registry: &mut CommandRegistry, world: &World) {
+        Self::pre_register(world);
+
         let cmd = Self::command();
         let name = cmd.get_name();
 

events/tag/src/command/fly.rs

@@ -1,49 +1,78 @@
 use clap::Parser;
-use flecs_ecs::core::{Entity, EntityViewGet, World, WorldGet};
+use flecs_ecs::{
+    core::{Entity, EntityViewGet, World, WorldGet, flecs},
+    macros::Component,
+};
 use hyperion::{
     net::{Compose, DataBundle, NetworkStreamRef, agnostic},
+    simulation::Player,
     system_registry::SystemId,
     valence_protocol::packets::play::{
         PlayerAbilitiesS2c, player_abilities_s2c::PlayerAbilitiesFlags,
     },
 };
 use hyperion_clap::{CommandPermission, MinecraftCommand};
 
+#[derive(Component)]
+#[meta]
+pub struct Flight {
+    pub allow: bool,
+}
+
 #[derive(Parser, CommandPermission, Debug)]
 #[command(name = "fly")]
 #[command_permission(group = "Moderator")]
 pub struct FlyCommand;
 
 impl MinecraftCommand for FlyCommand {
     fn execute(self, world: &World, caller: Entity) {
-        let chat = agnostic::chat("§aFlying enabled");
-
         world.get::<&Compose>(|compose| {
             caller
                 .entity_view(world)
-                .get::<&NetworkStreamRef>(|stream| {
-                    let packet = fly_packet();
+                .get::<(&mut Flight, &NetworkStreamRef)>(|(flight, stream)| {
+                    flight.allow = !flight.allow;
+
+                    let allow_flight = flight.allow;
+
+                    let chat_packet = if allow_flight {
+                        agnostic::chat("§aFlying enabled")
+                    } else {
+                        agnostic::chat("§cFlying disabled")
+                    };
+
+                    let packet = fly_packet(allow_flight);
 
                     let mut bundle = DataBundle::new(compose);
                     bundle.add_packet(&packet, world).unwrap();
-                    bundle.add_packet(&chat, world).unwrap();
+                    bundle.add_packet(&chat_packet, world).unwrap();
 
                     bundle.send(world, *stream, SystemId(8)).unwrap();
                 });
         });
     }
+
+    fn pre_register(world: &World) {
+        // register the component with meta meaning we can view the value in the flecs
+        // explorer UI
+        world.component::<Flight>().meta();
+
+        // whenever a Player component is added, we add the Flight component to them.
+        world
+            .component::<Player>()
+            .add_trait::<(flecs::With, Flight)>();
+    }
 }
 
-fn fly_packet() -> PlayerAbilitiesS2c {
+fn fly_packet(allow_flight: bool) -> PlayerAbilitiesS2c {
     const SPEED_METER_PER_SECOND: f32 = 10.92;
 
     // guessing.. idk what the actual conversion is
     const SOME_CONVERSION: f32 = SPEED_METER_PER_SECOND / 70.0;
 
     PlayerAbilitiesS2c {
         flags: PlayerAbilitiesFlags::default()
-            .with_flying(true)
-            .with_allow_flying(true),
+            .with_flying(allow_flight)
+            .with_allow_flying(allow_flight),
         flying_speed: SOME_CONVERSION,
         fov_modifier: 0.0,
     }