fix: use saturating_add on received_movement_packets (#894)

TestingPlant · web-flow · commit ec282f5c4d24 · 2025-05-17T20:13:30.000Z
Without saturating_add, the server may panic if it receives too many
movement packets within one tick.
diff --git a/crates/hyperion/src/simulation/handlers.rs b/crates/hyperion/src/simulation/handlers.rs
@@ -89,7 +89,7 @@ fn change_position_or_correct_client(
             .set(PendingTeleportation::new(pose.position));
     }
     query.view.get::<&mut MovementTracking>(|tracking| {
-        tracking.received_movement_packets += 1;
+        tracking.received_movement_packets = tracking.received_movement_packets.saturating_add(1);
         let y_delta = proposed.y - pose.y;
 
         if y_delta > 0. && tracking.was_on_ground && !on_ground {

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ fn change_position_or_correct_client(`
`89`	`89`	`.set(PendingTeleportation::new(pose.position));`
`90`	`90`	`}`
`91`	`91`	`query.view.get::<&mut MovementTracking>(\|tracking\| {`
`92`		`- tracking.received_movement_packets += 1;`
	`92`	`+ tracking.received_movement_packets = tracking.received_movement_packets.saturating_add(1);`
`93`	`93`	`let y_delta = proposed.y - pose.y;`
`94`	`94`
`95`	`95`	`if y_delta > 0. && tracking.was_on_ground && !on_ground {`