Skip to content

feat: Add impl From<http::HeaderName> for Vary #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

CosmicHorrorDev
Copy link
Contributor

@CosmicHorrorDev CosmicHorrorDev commented May 25, 2025

It seems like a good start since one of Vary's common forms is a list of HeaderNames


I went with this as the relatively non-controversial impl, but I think it would be nice if there was a FromIterator<HeaderName> for Vary impl as well (which I'd be happy to add if that sounds reasonable)

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea, thanks!

@seanmonstar seanmonstar merged commit 12fb1d7 into hyperium:master May 27, 2025
6 checks passed
@CosmicHorrorDev CosmicHorrorDev deleted the vary-from-header-name branch May 27, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants