Fix/panicgrb (#289)

newm4n · web-flow · commit 03efe7133106 · 2022-02-21T08:54:00.000+07:00
* Better make file

* Return the error after panic in LoadKnowledgeBaseFromReader, this to gain insight of what happened that causes panic when loading GRBs
diff --git a/ast/KnowledgeBase.go b/ast/KnowledgeBase.go
@@ -80,7 +80,8 @@ func (lib *KnowledgeLibrary) LoadKnowledgeBaseFromReader(reader io.Reader, overw
 	defer func() {
 		if r := recover(); r != nil {
 			retKb = nil
-			logrus.Panicf("panic recovered during LoadKnowledgeBaseFromReader. send us your report to https://github.com/hyperjumptech/grule-rule-engine/issues")
+			retErr = fmt.Errorf("panic recovered during LoadKnowledgeBaseFromReader, recover \"%v\". send us your report to https://github.com/hyperjumptech/grule-rule-engine/issues", r)
+			logrus.Panicf("panic recovered during LoadKnowledgeBaseFromReader, recover \"%v\". send us your report to https://github.com/hyperjumptech/grule-rule-engine/issues", r)
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,8 @@ func (lib *KnowledgeLibrary) LoadKnowledgeBaseFromReader(reader io.Reader, overw`
`80`	`80`	`defer func() {`
`81`	`81`	`if r := recover(); r != nil {`
`82`	`82`	`retKb = nil`
`83`		`- logrus.Panicf("panic recovered during LoadKnowledgeBaseFromReader. send us your report to https://github.com/hyperjumptech/grule-rule-engine/issues")`
	`83`	`+ retErr = fmt.Errorf("panic recovered during LoadKnowledgeBaseFromReader, recover \"%v\". send us your report to https://github.com/hyperjumptech/grule-rule-engine/issues", r)`
	`84`	`+ logrus.Panicf("panic recovered during LoadKnowledgeBaseFromReader, recover \"%v\". send us your report to https://github.com/hyperjumptech/grule-rule-engine/issues", r)`
`84`	`85`	`}`
`85`	`86`	`}()`
`86`	`87`