Skip to content

Return rule name as part of error in rule evaluation #425

Open
@vivlis

Description

@vivlis

I would like to propose change for error rule execution, so that outgoing error contains rule name. At the moment rule name with error is logged:
log.Errorf("Failed testing condition for rule : %s. Got error %v", ruleEntry.RuleName, err)
but not returned back from func,

log.Errorf("Failed testing condition for rule : %s. Got error %v", ruleEntry.RuleName, err)
if g.ReturnErrOnFailedRuleEvaluation {
return err
}

proposed:
err = fmt.Errorf("Failed testing condition for rule : %s. Got error %v", ruleEntry.RuleName, err)
log.Error(err)
if g.ReturnErrOnFailedRuleEvaluation {

					return err
				}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions