Skip to content

feat: add bip32 pub key derivation #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Jun 11, 2025

Description:

add pub key derivation

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/add-bip32-pub-key-derivation branch from 324e2a8 to 6f2525b Compare June 11, 2025 14:51
Copy link
Contributor

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @goncalo-frade-iohk.
One question: Is it possible to reduce the duplications in checking the input parameters?
It appears to have been performed in a couple of places.

@goncalo-frade-iohk goncalo-frade-iohk merged commit 3fef8f9 into main Jun 16, 2025
5 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/add-bip32-pub-key-derivation branch June 16, 2025 20:51
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperledger Identus - Roadmap Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
Development

Successfully merging this pull request may close these issues.

4 participants