Comment PR #502
Draft
Comment PR #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Co-authored-by: William Richter <88400283+WRRicht3r@users.noreply.github.com> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Co-authored-by: William Richter <88400283+WRRicht3r@users.noreply.github.com> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Co-authored-by: William Richter <88400283+WRRicht3r@users.noreply.github.com> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
[CI]: target `main` branch in GitHub workflows
Signed-off-by: 6r1d <vic.6r1d@gmail.com>
* [docs]: update version note in js guide Signed-off-by: 0x009922 <a.marcius26@gmail.com> * [chore]: fix formatting Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Fix docker-compose command
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: 6r1d <vic.6r1d@gmail.com> Co-authored-by: 0x009922 <a.marcius26@gmail.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
nxsaken
commented
Jul 8, 2024
There was a problem hiding this comment.
Should be renamed according to hyperledger-iroha/iroha#4810, see the change in the README for smart contracts
* Getting started update and overhaul Signed-off-by: a_zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * fix broken links Signed-off-by: a_zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * fix section links Signed-off-by: a_zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Language and structure improvements Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * External links and crate names fixes Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Switch to using cargo install for iroha binaries in getting started Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Minor post-review fixes Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Fixes and suggestions after review Signed-off-by: yamkovoy <b.yamkovoy@gmail.com> * Changes after discussion Signed-off-by: yamkovoy <b.yamkovoy@gmail.com> * Minor tweaks in instructions Signed-off-by: yamkovoy <b.yamkovoy@gmail.com> * Additional post-review updates Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * link fixes Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * final post-review changes Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> --------- Signed-off-by: a_zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: yamkovoy <b.yamkovoy@gmail.com> Co-authored-by: yamkovoy <b.yamkovoy@gmail.com>
Closed
* Update new structure with recent changes Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * tweaks to structure after discussions Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * tweaks to Iroha Explained section Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * format fix Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> --------- Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com>
* link fixes due to migration Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Update src/guide/tutorials/rust.md Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> --------- Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
misc: update dependencies Signed-off-by: qua <43530070+0x009922@users.noreply.github.com>
Signed-off-by: tarmovannas <tarmo@tarmovannas.com>
* link fixes due to migration Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Update src/guide/tutorials/rust.md Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> * Miscellaneous docs updates + testnet links + binaries reference Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Updates after review Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> * Fix for broken link Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> --------- Signed-off-by: a-zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
* fix: extend default theme correctly Signed-off-by: quacumque <quacumque@fastmail.jp> * docs: update torii reference according to `rc.1.0` Signed-off-by: quacumque <quacumque@fastmail.jp> * ci: bump node version Signed-off-by: quacumque <quacumque@fastmail.jp> * ci: update corepack to latest Signed-off-by: quacumque <quacumque@fastmail.jp> * docs: fix broken anchor Signed-off-by: quacumque <quacumque@fastmail.jp> * Apply suggestions from code review Co-authored-by: Alexandra Zorina <64249490+a-zorina@users.noreply.github.com> Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com> * docs: update iroha rev, revise query section Signed-off-by: qua <43530070+0x009922@users.noreply.github.com> * docs: refine queries table Signed-off-by: qua <43530070+0x009922@users.noreply.github.com> --------- Signed-off-by: quacumque <quacumque@fastmail.jp> Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com> Signed-off-by: qua <43530070+0x009922@users.noreply.github.com> Co-authored-by: quacumque <quacumque@fastmail.jp> Co-authored-by: Alexandra Zorina <64249490+a-zorina@users.noreply.github.com>
docs: update config endpoints Signed-off-by: quacumque <quacumque@fastmail.jp> Co-authored-by: quacumque <quacumque@fastmail.jp>
Co-authored-by: William Richter <88400283+WRRicht3r@users.noreply.github.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Co-authored-by: yamkovoy <100563712+yamkovoy@users.noreply.github.com> Co-authored-by: qua <quacumque@fastmail.jp>
Typo "mind assets" -> "mint assets" Signed-off-by: Mathieu Legrand <44833388+Tieumsan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to hopefully use for comments. Do not merge this.