adds news section WIP #522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WRRicht3r
commented
May 29, 2025
WRRicht3r
commented
- Adds news section to main menu
- Adds news overview page
- Adds updates from 16 to 23 May
Signed-off-by: William Richter <richter@soramitsu.co.jp>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: William Richter <richter@soramitsu.co.jp>
Signed-off-by: William Richter <richter@soramitsu.co.jp>
Signed-off-by: William Richter <richter@soramitsu.co.jp>
Signed-off-by: William Richter <richter@soramitsu.co.jp>
Signed-off-by: quacumque <quacumque@fastmail.jp>
Signed-off-by: quacumque <quacumque@fastmail.jp>
Signed-off-by: quacumque <quacumque@fastmail.jp>
Signed-off-by: William Richter <richter@soramitsu.co.jp>
0x009922
reviewed
Jun 3, 2025
src/news/dev-updates/may-23-30.md
Outdated
| This week highlighted the power of our open-source community: | ||
|
|
||
| - **External PRs:** A special shout-out to 0x009922 – their PR optimizing public key storage ([#5445](https://github.com/hyperledger-iroha/iroha/pull/5445)) was merged, improving Iroha’s performance. Community contributions like this are incredibly valuable, so thank you! | ||
| - **Issue Reports:** Community members also helped by reporting issues: for instance, user mversic opened the trigger-related bugs ([#5232](https://github.com/hyperledger-iroha/iroha/issues/5232), [#4937](https://github.com/hyperledger-iroha/iroha/issues/4937)) that spurred improvements in trigger handling, and nxsaken requested multi-architecture Docker support (#4687) which is now implemented. Erigara identified the trigger queue issue ([#4429](4429)) which has been fixed. These reports lead directly to a better Iroha – keep them coming! |
Signed-off-by: William Richter <richter@soramitsu.co.jp>
s8sato
reviewed
Jun 3, 2025
There was a problem hiding this comment.
- I primarily review PRs and issues that I author.
- Rather than proposing complete rewrites, I point out errors based on the assumption that we will regenerate the text from the feedback. Feel free to use this for prompt creation and Chatty’s training.
|
|
||
| ## Bug Fixes & Improvements | ||
|
|
||
| - **Trigger Execution Fix:** A critical fix was merged to the trigger system’s execution logic (PR [#5430](https://github.com/hyperledger-iroha/iroha/pull/5430)). Triggers (Iroha’s version of smart contracts) will now execute per-transaction with a depth limit. This change (a breaking update marked with `!`) resolves issues where triggers could fire too often or even recursively. It closes longstanding bugs like “Trigger that fires too often” and ensures more predictable trigger behavior going forward. |
There was a problem hiding this comment.
- Iroha’s triggers and ordinary smart contracts are actually completely different. Please refer to this comment for details.
- The
!mark does not indicate a critical change; it’s added whenever an API change occurs, even for minor updates. - For the intent behind #5430, see the abstract.
| 2. The nightly build workflow was tweaked to include the WASM module’s `Cargo.lock` and allow trivial numeric casts. This fixed a nagging lint error that was breaking pre-merge checks. The issue “`pr.yml` : pre_build fails with outdated lint checks” was promptly closed after this fix. | ||
| 3. An attempt to cache Rust artifacts for the WASM workspace (to speed up builds) was marked high-priority (PR [#5444](https://github.com/hyperledger-iroha/iroha/pull/5444)) but ultimately closed without merging – the team opted for the above Cargo.lock solution instead, simplifying the approach. | ||
|
|
||
| - **Documentation Updates:** Documentation got a polish: an issue to “correct the term ‘smart contract’ in docs was closed. Iroha 2 uses the term “trigger” for its smart-contract-like feature, so this change aligns the terminology and clears up confusion for developers reading the docs. Also, various minor doc warnings were fixed (no more stray warnings during doc generation). |
There was a problem hiding this comment.
The previous use of “smart contract” was correct, so #5363 was closed as “not planned.”
| ### Closed Issues: | ||
| Many issues were resolved this week, including: | ||
| 1. **[#5443](https://github.com/hyperledger-iroha/iroha/issues/5443) CI Lint Heisenbug** – The transient lint failure in PR builds was fixed by PR [#5448](https://github.com/hyperledger-iroha/iroha/pull/5448), and this issue is now closed. | ||
| 2. **[#5363](https://github.com/hyperledger-iroha/iroha/issues/5363) “Smart contract” terminology** – Documentation updated (as noted above) to use the correct terms. |
There was a problem hiding this comment.
The previous use of “smart contract” was correct, so #5363 was closed as “not planned.”
|
|
||
| This week highlighted the power of our open-source community: | ||
|
|
||
| - **External PRs:** A special shout-out to 0x009922 – their PR optimizing public key storage ([#5445](https://github.com/hyperledger-iroha/iroha/pull/5445)) was merged, improving Iroha’s performance. Community contributions like this are incredibly valuable, so thank you! |
| This week highlighted the power of our open-source community: | ||
|
|
||
| - **External PRs:** A special shout-out to 0x009922 – their PR optimizing public key storage ([#5445](https://github.com/hyperledger-iroha/iroha/pull/5445)) was merged, improving Iroha’s performance. Community contributions like this are incredibly valuable, so thank you! | ||
| - **Issue Reports:** Community members also helped by reporting issues: for instance, user mversic opened the trigger-related bugs ([#5232](https://github.com/hyperledger-iroha/iroha/issues/5232), [#4937](https://github.com/hyperledger-iroha/iroha/issues/4937)) that spurred improvements in trigger handling, and nxsaken requested multi-architecture Docker support ([#4687](https://github.com/hyperledger-iroha/iroha/issues/4687)) which is now implemented. Erigara identified the trigger queue issue ([#4429](https://github.com/hyperledger-iroha/iroha/issues/4429)) which has been fixed. These reports lead directly to a better Iroha – keep them coming! |
There was a problem hiding this comment.
This may be intentional padding, but it refers to topics from long ago and to members who have already left.
s8sato
reviewed
Jun 3, 2025
|
|
||
| ## Bug Fixes and Issue Resolutions🐞 | ||
|
|
||
| - **WASM Event Coverage:** The team closed an issue related to WebAssembly smart contracts not properly declaring all possible events they can emit. The WASM executor now declares the full union of possible events, ensuring that event handling logic is aware of every event type a contract might produce. This fix improves correctness and transparency in Iroha’s contract system. |
There was a problem hiding this comment.
This is entirely fabricated. Please distinguish between "closed as not planned" and "closed as completed".
|
|
||
| - **WASM Event Coverage:** The team closed an issue related to WebAssembly smart contracts not properly declaring all possible events they can emit. The WASM executor now declares the full union of possible events, ensuring that event handling logic is aware of every event type a contract might produce. This fix improves correctness and transparency in Iroha’s contract system. | ||
|
|
||
| - **Deduplicating WASM Blobs:** Another fix addressed a problem of duplicate WASM binaries in the system. The resolution ensures that WASM blobs are not redundantly stored or processed (“`Dedup wasm blobs`”), which reduces unnecessary memory and storage overhead. This optimization makes Iroha’s handling of smart contract modules more efficient. |
There was a problem hiding this comment.
This remains unresolved. Please distinguish between "closed as duplicate" and "closed as completed".
|
Closed as this is not the appropriate place for such updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.