Skip to content

Conversation

@0x009922
Copy link
Contributor

Solution described in #210 (comment)

  • Remove @iroha/crypto-target-*
  • Put the .wasm directly into @iroha/core/crypto, import with a tricky glue
  • "Just works" in Deno, Node, Bun, native browser
  • For bundlers, requires plugins to support native .wasm ESM imports

Close #209
Close #221

…iroha#221)

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 self-assigned this Feb 18, 2025
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 changed the title feat(core): unified .wasm import (#209, #221) fix(core)!: unified .wasm import (#209, #221) Feb 18, 2025
@0x009922 0x009922 marked this pull request as ready for review February 18, 2025 07:33
@0x009922 0x009922 merged commit 6ccaf6a into hyperledger-iroha:main Feb 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@iroha/crypto-target-node@0.1.0 has broken requires Update crypto-wasm README

1 participant