build(Dockerfile): pin platform to linux/amd64, refactor
#4688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxsaken
requested review from
0x009922,
DCNick3,
Erigara,
SamHSmith,
VAmuzing,
dima74,
mversic,
outoftardis and
s8sato
as code owners
dima74
reviewed
Jun 4, 2024
0x009922
previously approved these changes
Jun 6, 2024
Contributor
0x009922
left a comment
0x009922
left a comment
There was a problem hiding this comment.
Haven't checked whether the image works, but LGTM
Contributor
Author
|
I was able to set up a network and run some CLI commands. |
0x009922
approved these changes
Jun 10, 2024
mversic
approved these changes
Jun 10, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the Dockerfile only supports building for
linux/amd64, let's pin it for now before we introduce multi-arch builds. Unused (seemingly) dependencies and unnecessaryRUNlayers have been removed/compressed.Linked issue
Related to #4687.
Benefits
Docker builds should be faster, unneeded stuff doesn't clutter the Dockerfile.
Checklist
CONTRIBUTING.md