fix(golangci.yml): Exclude generated file from linter

chore: Refactor for linter

Signed-off-by: Sophia Koehler <sophia@perun.network>

Author: sophia1ch

.golangci.yml

@@ -48,6 +48,8 @@ linters-settings:
     template-path: ".scripts/copyright-notice"
   forbidigo:
     forbid:
+      - exclude-rules:
+          - path: ".*\\.pb\\.go$" # Exclude protobuf generated files.
       # Forbid functions to start with "get" or "Get".
       - ^[Gg]et.*$
       - ^[Ee]quals$

backend/sim/channel/asset.go

@@ -44,7 +44,7 @@ func NewRandomAsset(rng *rand.Rand) *Asset {
 // MarshalBinary marshals the address into its binary representation.
 func (a Asset) MarshalBinary() ([]byte, error) {
 	data := make([]byte, assetLen)
-	byteOrder.PutUint64(data, uint64(a.ID))
+	byteOrder.PutUint64(data, uint64(a.ID)) //nolint:gosec
 	return data, nil
 }
 

backend/sim/channel/backend.go

@@ -37,7 +37,7 @@ func (*backend) CalcID(p *channel.Params) (id channel.ID, err error) {
 	w := sha256.New()
 
 	// Write Parts
-	if err := perunio.Encode(w, wallet.AddressMapArray{p.Parts}); err != nil {
+	if err := perunio.Encode(w, wallet.AddressMapArray{Addr: p.Parts}); err != nil {
 		log.Panic("Could not write to sha256 hasher")
 	}
 

channel/allocation.go

@@ -127,7 +127,7 @@ func NewAllocation(numParts int, backends []wallet.BackendID, assets ...Asset) *
 func (a *Allocation) AssetIndex(asset Asset) (Index, bool) {
 	for idx, _asset := range a.Assets {
 		if asset.Equal(_asset) {
-			return Index(idx), true
+			return Index(idx), true //nolint:gosec
 		}
 	}
 	return 0, false
@@ -194,15 +194,11 @@ func (a *Allocation) NumParts() int {
 func (a Allocation) Clone() (clone Allocation) {
 	if a.Backends != nil {
 		clone.Backends = make([]wallet.BackendID, len(a.Backends))
-		for i, bID := range a.Backends {
-			clone.Backends[i] = bID
-		}
+		copy(clone.Backends, a.Backends)
 	}
 	if a.Assets != nil {
 		clone.Assets = make([]Asset, len(a.Assets))
-		for i, asset := range a.Assets {
-			clone.Assets[i] = asset
-		}
+		copy(clone.Assets, a.Assets)
 	}
 
 	clone.Balances = a.Balances.Clone()
@@ -334,7 +330,7 @@ func (a Allocation) Encode(w io.Writer) error {
 	}
 	// encode assets
 	for i, asset := range a.Assets {
-		if err := perunio.Encode(w, uint32(a.Backends[i])); err != nil {
+		if err := perunio.Encode(w, uint32(a.Backends[i])); err != nil { //nolint:gosec
 			return errors.WithMessagef(err, "encoding backends %d", i)
 		}
 		if err := perunio.Encode(w, asset); err != nil {
@@ -634,7 +630,7 @@ func AssertAssetsEqual(a []Asset, b []Asset) error {
 	return nil
 }
 
-// AssertAssetsEqual returns an error if the given assets are not equal.
+// AssertBackendsEqual returns an error if the given assets are not equal.
 func AssertBackendsEqual(a []wallet.BackendID, b []wallet.BackendID) error {
 	if len(a) != len(b) {
 		return errors.New("length mismatch")

channel/allocation_test.go

@@ -278,7 +278,7 @@ func TestAllocationValidLimits(t *testing.T) {
 		}
 
 		allocation.Assets = test.NewRandomAssets(rng, test.WithNumAssets(x.numAssets))
-		for i, _ := range allocation.Assets {
+		for i := range allocation.Assets {
 			allocation.Backends[i] = 0
 		}
 

channel/machine.go

@@ -228,7 +228,7 @@ func (m *machine) Sig() (sig wallet.Sig, err error) {
 			sig, err = Sign(acc, m.stagingTX.State, b)
 			if err == nil {
 				m.stagingTX.Sigs[m.idx] = sig
-				return
+				return sig, nil
 			}
 		}
 	} else {

channel/multi/asset.go

@@ -27,6 +27,7 @@ type (
 		AssetID() AssetID
 	}
 
+	// AssetID represents an asset identifier.
 	AssetID interface {
 		BackendID() uint32
 		LedgerId() LedgerID

channel/params.go

@@ -35,7 +35,7 @@ const IDLen = 32
 // ID represents a channelID.
 type ID = [IDLen]byte
 
-// IDMap is a map of IDs with keys corresponding to backendIDs
+// IDMap is a map of IDs with keys corresponding to backendIDs.
 type IDMap map[wallet.BackendID]ID
 
 // MaxNonceLen is the maximum byte count of a nonce.
@@ -75,12 +75,12 @@ func EqualIDs(a, b map[wallet.BackendID]ID) bool {
 }
 
 func (ids IDMap) Encode(w stdio.Writer) error {
-	length := int32(len(ids))
+	length := int32(len(ids)) //nolint:gosec
 	if err := perunio.Encode(w, length); err != nil {
 		return errors.WithMessage(err, "encoding map length")
 	}
 	for i, id := range ids {
-		if err := perunio.Encode(w, int32(i)); err != nil {
+		if err := perunio.Encode(w, int32(i)); err != nil { //nolint:gosec
 			return errors.WithMessage(err, "encoding map index")
 		}
 		if err := perunio.Encode(w, id); err != nil {
@@ -112,14 +112,11 @@ func (ids *IDMap) Decode(r stdio.Reader) error {
 
 func IDKey(ids IDMap) string {
 	var buff strings.Builder
-	// Encode the number of elements in the map first.
-	length := int32(len(ids)) // Using int32 to encode the length
-	err := binary.Write(&buff, binary.BigEndian, length)
+	length := int32(len(ids))                            //nolint:gosec
+	err := binary.Write(&buff, binary.BigEndian, length) //nolint:gosec
 	if err != nil {
 		log.Panic("could not encode map length in Key: ", err)
-
 	}
-	// Iterate over the map and encode each key-value pair.
 	sortedKeys, sortedIDs := sortIDMap(ids)
 	for i, id := range sortedIDs {
 		if err := binary.Write(&buff, binary.BigEndian, int32(sortedKeys[i])); err != nil {
@@ -133,9 +130,9 @@ func IDKey(ids IDMap) string {
 }
 
 func sortIDMap(ids IDMap) ([]wallet.BackendID, []ID) {
-	var indexes []int
+	indexes := make([]int, len(ids))
 	for i := range ids {
-		indexes = append(indexes, int(i))
+		indexes[i] = int(i)
 	}
 	sort.Ints(indexes)
 	sortedIndexes := make([]wallet.BackendID, len(indexes))
@@ -279,12 +276,12 @@ func NewParamsUnsafe(challengeDuration uint64, parts []map[wallet.BackendID]wall
 	return p
 }
 
-// CloneAddress returns a clone of an Address using its binary marshaling
+// CloneAddresses returns a clone of an Address using its binary marshaling
 // implementation. It panics if an error occurs during binary (un)marshaling.
 func CloneAddresses(as []map[wallet.BackendID]wallet.Address) []map[wallet.BackendID]wallet.Address {
-	var cloneMap []map[wallet.BackendID]wallet.Address
-	for _, a := range as {
-		cloneMap = append(cloneMap, wallet.CloneAddressesMap(a))
+	cloneMap := make([]map[wallet.BackendID]wallet.Address, len(as))
+	for i, a := range as {
+		cloneMap[i] = wallet.CloneAddressesMap(a)
 	}
 	return cloneMap
 }
@@ -304,7 +301,6 @@ func (p *Params) Clone() *Params {
 
 // Encode uses the pkg/io module to serialize a params instance.
 func (p *Params) Encode(w stdio.Writer) error {
-
 	return perunio.Encode(w,
 		p.ChallengeDuration,
 		wallet.AddressMapArray{Addr: p.Parts},

channel/params_test.go

@@ -35,7 +35,6 @@ func TestParams_Clone(t *testing.T) {
 	require.Equalf(t, params.App, clone.App, "Clone() = %v, want %v", clone, params)
 	require.Equalf(t, params.ChallengeDuration, clone.ChallengeDuration, "Clone() = %v, want %v", clone, params)
 	require.Equalf(t, params.Nonce, clone.Nonce, "Clone() = %v, want %v", clone, params)
-
 }
 
 func TestParams_Serializer(t *testing.T) {

channel/persistence/nonpersister.go

@@ -37,6 +37,7 @@ type nonPersistRestorer struct{}
 func (nonPersistRestorer) ChannelCreated(context.Context, channel.Source, []map[wallet.BackendID]wire.Address, *map[wallet.BackendID]channel.ID) error {
 	return nil
 }
+
 func (nonPersistRestorer) ChannelRemoved(context.Context, map[wallet.BackendID]channel.ID) error {
 	return nil
 }