chore(all): Add nolint flags for conversions

sophia1ch · sophia1ch · commit 98b900bb6c99 · 2024-12-19T13:03:35.000+01:00
Signed-off-by: Sophia Koehler &lt;sophia@perun.network&gt;
diff --git a/apps/payment/app_internal_test.go b/apps/payment/app_internal_test.go
@@ -95,7 +95,7 @@ func TestApp_ValidTransition(t *testing.T) {
 			numParticipants := len(tt.from[0])
 			for i := 0; i < numParticipants; i++ {
 				// valid self-transition
-				assert.NoError(app.ValidTransition(nil, from, from, channel.Index(i)))
+				assert.NoError(app.ValidTransition(nil, from, from, channel.Index(i))) //nolint:gosec
 			}
 
 			for _, tto := range tt.tos {
@@ -105,7 +105,7 @@ func TestApp_ValidTransition(t *testing.T) {
 					test.WithBalances(asBalances(tto.alloc...)...),
 				)
 				for i := 0; i < numParticipants; i++ {
-					err := app.ValidTransition(nil, from, to, channel.Index(i))
+					err := app.ValidTransition(nil, from, to, channel.Index(i)) //nolint:gosec
 					if i == tto.valid {
 						assert.NoError(err)
 					} else {
diff --git a/backend/sim/channel/asset.go b/backend/sim/channel/asset.go
@@ -53,7 +53,7 @@ func (a *Asset) UnmarshalBinary(data []byte) error {
 	if len(data) != assetLen {
 		return fmt.Errorf("unexpected length %d, want %d", len(data), assetLen) //nolint:goerr113  // We do not want to define this as constant error.
 	}
-	a.ID = int64(byteOrder.Uint64(data))
+	a.ID = int64(byteOrder.Uint64(data)) //nolint:gosec
 	return nil
 }
 
diff --git a/channel/allocation.go b/channel/allocation.go
@@ -325,7 +325,7 @@ func (a Allocation) Encode(w io.Writer) error {
 			err, "invalid allocations cannot be encoded, got %v", a)
 	}
 	// encode dimensions
-	if err := perunio.Encode(w, Index(len(a.Assets)), Index(len(a.Balances[0])), Index(len(a.Locked))); err != nil {
+	if err := perunio.Encode(w, Index(len(a.Assets)), Index(len(a.Balances[0])), Index(len(a.Locked))); err != nil { //nolint:gosec
 		return err
 	}
 	// encode assets
@@ -436,7 +436,7 @@ func (b Balances) Encode(w io.Writer) error {
 		return errors.Errorf("expected maximum number of parts %d, got %d", MaxNumParts, numParts)
 	}
 
-	if err := perunio.Encode(w, Index(numAssets), Index(numParts)); err != nil {
+	if err := perunio.Encode(w, Index(numAssets), Index(numParts)); err != nil { //nolint:gosec
 		return errors.WithMessage(err, "encoding dimensions")
 	}
 	for i := range b {
@@ -667,7 +667,7 @@ func (s SubAlloc) Encode(w io.Writer) error {
 			err, "invalid sub-allocations cannot be encoded, got %v", s)
 	}
 	// encode ID and dimension
-	if err := perunio.Encode(w, IDMap(s.ID), Index(len(s.Bals))); err != nil {
+	if err := perunio.Encode(w, IDMap(s.ID), Index(len(s.Bals))); err != nil { //nolint:gosec
 		return errors.WithMessagef(
 			err, "encoding sub-allocation ID or dimension, id %v", s.ID)
 	}
@@ -679,7 +679,7 @@ func (s SubAlloc) Encode(w io.Writer) error {
 		}
 	}
 	// Encode IndexMap.
-	if err := perunio.Encode(w, Index(len(s.IndexMap))); err != nil {
+	if err := perunio.Encode(w, Index(len(s.IndexMap))); err != nil { //nolint:gosec
 		return errors.WithMessage(err, "encoding length of index map")
 	}
 	for i, x := range s.IndexMap {
diff --git a/channel/machine.go b/channel/machine.go
@@ -151,7 +151,7 @@ func newMachine(acc map[wallet.BackendID]wallet.Account, params Params) (*machin
 	return &machine{
 		phase:     InitActing,
 		acc:       acc,
-		idx:       Index(idx),
+		idx:       Index(idx), //nolint:gosec
 		params:    params,
 		Embedding: log.MakeEmbedding(log.WithField("ID", params.id)),
 	}, nil
@@ -190,7 +190,7 @@ func (m *machine) Params() *Params {
 
 // N returns the number of participants of the channel parameters of this machine.
 func (m *machine) N() Index {
-	return Index(len(m.params.Parts))
+	return Index(len(m.params.Parts)) //nolint:gosec
 }
 
 // Phase returns the current phase.
diff --git a/channel/multi/funder.go b/channel/multi/funder.go
@@ -62,7 +62,7 @@ func (f *Funder) SetEgoisticChain(l AssetID, id int, egoistic bool) {
 // channel. If any of the funder calls fails, the method returns an error.
 func (f *Funder) Fund(ctx context.Context, request channel.FundingReq) error {
 	// Define funding timeout.
-	d := time.Duration(request.Params.ChallengeDuration) * time.Second
+	d := time.Duration(request.Params.ChallengeDuration) * time.Second //nolint:gosec
 	ctx, cancel := context.WithTimeout(ctx, d)
 	defer cancel()
 
diff --git a/channel/params.go b/channel/params.go
@@ -112,14 +112,14 @@ func (ids *IDMap) Decode(r stdio.Reader) error {
 
 func IDKey(ids IDMap) string {
 	var buff strings.Builder
-	length := int32(len(ids))                            //nolint:gosec
-	err := binary.Write(&buff, binary.BigEndian, length) //nolint:gosec
+	length := int32(len(ids)) //nolint:gosec
+	err := binary.Write(&buff, binary.BigEndian, length)
 	if err != nil {
 		log.Panic("could not encode map length in Key: ", err)
 	}
 	sortedKeys, sortedIDs := sortIDMap(ids)
 	for i, id := range sortedIDs {
-		if err := binary.Write(&buff, binary.BigEndian, int32(sortedKeys[i])); err != nil {
+		if err := binary.Write(&buff, binary.BigEndian, int32(sortedKeys[i])); err != nil { //nolint:gosec
 			log.Panicf("could not encode map key: " + err.Error())
 		}
 		if err := perunio.Encode(&buff, id); err != nil {
diff --git a/channel/persistence/statemachine_test.go b/channel/persistence/statemachine_test.go
@@ -76,7 +76,7 @@ func TestStateMachine(t *testing.T) {
 				sig, err = channel.Sign(acc, csm.StagingState(), b)
 				require.NoError(err)
 			}
-			err = sm.AddSig(ctx, channel.Index(i), sig)
+			err = sm.AddSig(ctx, channel.Index(i), sig) //nolint:gosec
 			require.NoError(err)
 			tpr.AssertEqual(csm)
 		}
@@ -152,7 +152,7 @@ func TestStateMachine(t *testing.T) {
 
 	// Set Progressed
 	timeout := ctest.NewRandomTimeout(rng)
-	idx := channel.Index(rng.Intn(s.NumParts()))
+	idx := channel.Index(rng.Intn(s.NumParts())) //nolint:gosec
 	e := channel.NewProgressedEvent(s.ID[0], timeout, s, idx)
 	err = sm.SetProgressed(ctx, e)
 	require.NoError(err)
diff --git a/channel/test/randomizer.go b/channel/test/randomizer.go
@@ -269,7 +269,7 @@ func NewRandomChannelID(rng *rand.Rand, opts ...RandomOpt) (id map[wallet.Backen
 		for _, b := range bIds {
 			cId := [32]byte{}
 			rng.Read(cId[:])
-			id[wallet.BackendID(b)] = cId
+			id[b] = cId
 		}
 		return
 	}
@@ -281,7 +281,7 @@ func NewRandomChannelID(rng *rand.Rand, opts ...RandomOpt) (id map[wallet.Backen
 	} else {
 		cId := [32]byte{}
 		rng.Read(cId[:])
-		id[wallet.BackendID(bId)] = cId
+		id[bId] = cId
 	}
 	return
 }
@@ -299,7 +299,7 @@ func NewRandomChannelIDs(rng *rand.Rand, n int) (ids []map[wallet.BackendID]chan
 func NewRandomIndexMap(rng *rand.Rand, numParts int, numPartsParent int) (m []channel.Index) {
 	m = make([]channel.Index, numParts)
 	for i := range m {
-		m[i] = channel.Index(rng.Intn(numPartsParent))
+		m[i] = channel.Index(rng.Intn(numPartsParent)) //nolint:gosec
 	}
 	return
 }
diff --git a/client/channelconn.go b/client/channelconn.go
@@ -104,7 +104,7 @@ func (c *channelConn) Close() error {
 func (c *channelConn) Send(ctx context.Context, msg wire.Msg) error {
 	var eg errgroup.Group
 	for i, peer := range c.peers {
-		if channel.Index(i) == c.idx {
+		if channel.Index(i) == c.idx { //nolint:gosec
 			continue // skip own peer
 		}
 		c.log.WithField("peer", peer).Debugf("channelConn: publishing message: %v: %+v", msg.Type(), msg)
@@ -168,5 +168,5 @@ func (r *channelMsgRecv) Next(ctx context.Context) (channel.Index, ChannelMsg, e
 	if !ok {
 		return 0, nil, errors.Errorf("unexpected message type: expected ChannelMsg, got %T", env.Msg)
 	}
-	return channel.Index(idx), msg, nil // predicate must guarantee that the conversion is safe
+	return channel.Index(idx), msg, nil //nolint:gosec
 }
diff --git a/client/restore_internal_test.go b/client/restore_internal_test.go
@@ -120,7 +120,7 @@ func mkRndChan(rng *rand.Rand, bID wallet.BackendID) *persistence.Channel {
 		parts[i] = map[wallet.BackendID]wallet.Address{bID: wallettest.NewRandomAccount(rng, bID).Address()}
 	}
 	ch := persistence.NewChannel()
-	ch.IdxV = channel.Index(rng.Intn(channel.MaxNumParts))
+	ch.IdxV = channel.Index(rng.Intn(channel.MaxNumParts)) //nolint:gosec
 	ch.ParamsV = test.NewRandomParams(rng, test.WithParts(parts))
 	sigs := make([]bool, channel.MaxNumParts)
 	opts := test.WithParams(ch.ParamsV)
diff --git a/client/serialize.go b/client/serialize.go
@@ -33,7 +33,7 @@ type (
 
 // Encode encodes the object to the writer.
 func (a channelIDsWithLen) Encode(w io.Writer) (err error) {
-	length := int32(len(a))
+	length := int32(len(a)) //nolint:gosec
 	if err := perunio.Encode(w, length); err != nil {
 		return errors.WithMessage(err, "encoding array length")
 	}
@@ -62,7 +62,7 @@ func (a *channelIDsWithLen) Decode(r io.Reader) (err error) {
 
 // Encode encodes the object to the writer.
 func (a indexMapsWithLen) Encode(w io.Writer) (err error) {
-	err = perunio.Encode(w, sliceLen(len(a)))
+	err = perunio.Encode(w, sliceLen(len(a))) //nolint:gosec
 	if err != nil {
 		return
 	}
@@ -94,7 +94,7 @@ func (a *indexMapsWithLen) Decode(r io.Reader) (err error) {
 
 // Encode encodes the object to the writer.
 func (a indexMapWithLen) Encode(w io.Writer) (err error) {
-	err = perunio.Encode(w, sliceLen(len(a)))
+	err = perunio.Encode(w, sliceLen(len(a))) //nolint:gosec
 	if err != nil {
 		return
 	}
diff --git a/client/sync.go b/client/sync.go
@@ -69,7 +69,8 @@ func (c *Client) handleSyncMsg(peer map[wallet.BackendID]wire.Address, msg *Chan
 
 // syncChannel synchronizes the channel state with the given peer and modifies
 // the current state if required.
-// nolint:unused
+//
+//nolint:unused
 func (c *Client) syncChannel(ctx context.Context, ch *persistence.Channel, p map[wallet.BackendID]wire.Address) (err error) {
 	recv := wire.NewReceiver()
 	defer recv.Close() // ignore error
@@ -119,7 +120,8 @@ func (c *Client) syncChannel(ctx context.Context, ch *persistence.Channel, p map
 }
 
 // validateMessage validates the remote channel sync message.
-// nolint:unused, nestif
+//
+//nolint:unused, nestif
 func validateMessage(ch *persistence.Channel, msg *ChannelSyncMsg) error {
 	v := ch.CurrentTX().Version
 	mv := msg.CurrentTX.Version
@@ -151,7 +153,7 @@ func validateMessage(ch *persistence.Channel, msg *ChannelSyncMsg) error {
 	return nil
 }
 
-// nolint:unused
+//nolint:unused
 func revisePhase(ch *persistence.Channel) error {
 	//nolint:gocritic
 	if ch.PhaseV <= channel.Funding && ch.CurrentTXV.Version == 0 {
diff --git a/client/test/backend.go b/client/test/backend.go
@@ -228,7 +228,7 @@ func (b *MockBackend) Progress(_ context.Context, req channel.ProgressReq) error
 	b.mu.Lock()
 	defer b.mu.Unlock()
 
-	timeout := time.Now().Add(time.Duration(req.Params.ChallengeDuration) * time.Millisecond)
+	timeout := time.Now().Add(time.Duration(req.Params.ChallengeDuration) * time.Millisecond) //nolint:gosec
 	b.setLatestEvent(
 		req.Params.ID(),
 		channel.NewProgressedEvent(
diff --git a/client/test/mallory.go b/client/test/mallory.go
@@ -66,7 +66,7 @@ func (r *Mallory) exec(_cfg ExecConfig, ch *paymentChannel) {
 	r.waitStage()
 
 	// Register version 0 AdjudicatorReq
-	challengeDuration := time.Duration(ch.Channel.Params().ChallengeDuration) * time.Second
+	challengeDuration := time.Duration(ch.Channel.Params().ChallengeDuration) * time.Second //nolint:gosec
 	regCtx, regCancel := context.WithTimeout(context.Background(), r.timeout)
 	defer regCancel()
 	r.log.Debug("Registering version 0 state.")
diff --git a/client/test/updatemsgs.go b/client/test/updatemsgs.go
@@ -125,7 +125,7 @@ func newRandomMsgChannelUpdate(rng *rand.Rand) *client.ChannelUpdateMsg {
 	return &client.ChannelUpdateMsg{
 		ChannelUpdate: client.ChannelUpdate{
 			State:    state,
-			ActorIdx: channel.Index(rng.Intn(state.NumParts())),
+			ActorIdx: channel.Index(rng.Intn(state.NumParts())), //nolint:gosec
 		},
 		Sig: sig,
 	}
diff --git a/client/virtual_channel.go b/client/virtual_channel.go
@@ -185,7 +185,7 @@ func (c *Client) persistVirtualChannel(ctx context.Context, parent *Channel, pee
 	}
 
 	for i, sig := range sigs {
-		err = ch.machine.AddSig(ctx, channel.Index(i), sig)
+		err = ch.machine.AddSig(ctx, channel.Index(i), sig) //nolint:gosec
 		if err != nil {
 			return nil, err
 		}
@@ -223,7 +223,7 @@ func (c *Channel) pushVirtualUpdate(ctx context.Context, state *channel.State, s
 	}
 
 	for i, sig := range sigs {
-		idx := channel.Index(i)
+		idx := channel.Index(i) //nolint:gosec
 		if err := m.AddSig(ctx, idx, sig); err != nil {
 			return err
 		}
diff --git a/client/virtual_channel_settlement.go b/client/virtual_channel_settlement.go
@@ -214,7 +214,7 @@ func (c *Channel) forceFinalState(ctx context.Context, final channel.SignedState
 		return err
 	}
 	for i, sig := range final.Sigs {
-		if err := c.machine.AddSig(ctx, channel.Index(i), sig); err != nil {
+		if err := c.machine.AddSig(ctx, channel.Index(i), sig); err != nil { //nolint:gosec
 			return err
 		}
 	}
diff --git a/wallet/address.go b/wallet/address.go
@@ -134,12 +134,12 @@ type AddrKey string
 // Encode encodes first the length of the map,
 // then all Addresses and their key in the map.
 func (a AddressDecMap) Encode(w stdio.Writer) error {
-	length := int32(len(a))
+	length := int32(len(a)) //nolint:gosec
 	if err := perunio.Encode(w, length); err != nil {
 		return errors.WithMessage(err, "encoding map length")
 	}
 	for i, addr := range a {
-		if err := perunio.Encode(w, int32(i)); err != nil {
+		if err := perunio.Encode(w, int32(i)); err != nil { //nolint:gosec
 			return errors.WithMessage(err, "encoding map index")
 		}
 		if err := perunio.Encode(w, addr); err != nil {
@@ -152,7 +152,7 @@ func (a AddressDecMap) Encode(w stdio.Writer) error {
 // Encode encodes first the length of the array,
 // then all AddressDecMaps in the array.
 func (a AddressMapArray) Encode(w stdio.Writer) error {
-	length := int32(len(a.Addr))
+	length := int32(len(a.Addr)) //nolint:gosec
 	if err := perunio.Encode(w, length); err != nil {
 		return errors.WithMessage(err, "encoding array length")
 	}
diff --git a/wire/address.go b/wire/address.go
@@ -58,12 +58,12 @@ type AddressDecMap map[wallet.BackendID]Address
 // Encode encodes first the length of the map,
 // then all Addresses and their key in the map.
 func (a AddressDecMap) Encode(w stdio.Writer) error {
-	length := int32(len(a)) // Using int32 to encode the length
+	length := int32(len(a)) //nolint:gosec
 	if err := perunio.Encode(w, length); err != nil {
 		return errors.WithMessage(err, "encoding map length")
 	}
 	for i, addr := range a {
-		if err := perunio.Encode(w, int32(i)); err != nil {
+		if err := perunio.Encode(w, int32(i)); err != nil { //nolint:gosec
 			return errors.WithMessage(err, "encoding map index")
 		}
 		if err := perunio.Encode(w, addr); err != nil {
@@ -76,7 +76,7 @@ func (a AddressDecMap) Encode(w stdio.Writer) error {
 // Encode encodes first the length of the array,
 // then all AddressDecMaps in the array.
 func (a AddressMapArray) Encode(w stdio.Writer) error {
-	length := int32(len(a)) // Using int32 to encode the length
+	length := int32(len(a)) //nolint:gosec
 	if err := perunio.Encode(w, length); err != nil {
 		return errors.WithMessage(err, "encoding array length")
 	}
@@ -127,8 +127,6 @@ func (a *AddressMapArray) Decode(r stdio.Reader) (err error) {
 
 // IndexOfAddr returns the index of the given address in the address slice,
 // or -1 if it is not part of the slice.
-//
-//nolint:unused
 func IndexOfAddr(addrs []Address, addr Address) int {
 	for i, a := range addrs {
 		if addr.Equal(a) {
diff --git a/wire/net/exchange_addr.go b/wire/net/exchange_addr.go
@@ -82,8 +82,10 @@ func ExchangeAddrsActive(ctx context.Context, id map[wallet.BackendID]wire.Accou
 			err = errors.WithMessage(err, "receiving message")
 		} else if _, ok := e.Msg.(*wire.AuthResponseMsg); !ok {
 			err = errors.Errorf("expected AuthResponse wire msg, got %v", e.Msg.Type())
-		} else if check := VerifyAddressSignature(peer, e.Msg.(*wire.AuthResponseMsg).Signature); check != nil {
-			err = errors.WithMessage(err, "verifying peer address's signature")
+		} else if msg, ok := e.Msg.(*wire.AuthResponseMsg); ok {
+			if check := VerifyAddressSignature(peer, msg.Signature); check != nil {
+				err = errors.WithMessage(check, "verifying peer address's signature")
+			}
 		} else if !test.EqualWireMaps(e.Recipient, wire.AddressMapfromAccountMap(id)) &&
 			!test.EqualWireMaps(e.Sender, peer) {
 			err = NewAuthenticationError(e.Sender, e.Recipient, wire.AddressMapfromAccountMap(id), "unmatched response sender or recipient")
@@ -112,8 +114,10 @@ func ExchangeAddrsPassive(ctx context.Context, id map[wallet.BackendID]wire.Acco
 			err = errors.Errorf("expected AuthResponse wire msg, got %v", e.Msg.Type())
 		} else if !test.EqualWireMaps(e.Recipient, addrs) {
 			err = NewAuthenticationError(e.Sender, e.Recipient, wire.AddressMapfromAccountMap(id), "unmatched response sender or recipient")
-		} else if err = VerifyAddressSignature(e.Sender, e.Msg.(*wire.AuthResponseMsg).Signature); err != nil {
-			err = errors.WithMessage(err, "verifying peer address's signature")
+		} else if msg, ok := e.Msg.(*wire.AuthResponseMsg); ok {
+			if err = VerifyAddressSignature(e.Sender, msg.Signature); err != nil {
+				err = errors.WithMessage(err, "verifying peer address's signature")
+			}
 		}
 
 		if err != nil {
diff --git a/wire/net/simple/address.go b/wire/net/simple/address.go
@@ -47,7 +47,7 @@ func (a *Address) MarshalBinary() ([]byte, error) {
 	var buf bytes.Buffer
 
 	// Encode the length of the name string and the name itself
-	nameLen := uint16(len(a.Name))
+	nameLen := uint16(len(a.Name)) //nolint:gosec
 	if err := binary.Write(&buf, binary.BigEndian, nameLen); err != nil {
 		return nil, err
 	}
@@ -110,7 +110,7 @@ func (a *Address) Backend() wallet.BackendID {
 func encodePublicKey(buf *bytes.Buffer, key *rsa.PublicKey) error {
 	// Encode modulus length and modulus
 	modulusBytes := key.N.Bytes()
-	modulusLen := uint16(len(modulusBytes))
+	modulusLen := uint16(len(modulusBytes)) //nolint:gosec
 	if err := binary.Write(buf, binary.BigEndian, modulusLen); err != nil {
 		return err
 	}
@@ -119,7 +119,7 @@ func encodePublicKey(buf *bytes.Buffer, key *rsa.PublicKey) error {
 	}
 
 	// Encode public exponent
-	if err := binary.Write(buf, binary.BigEndian, int32(key.E)); err != nil {
+	if err := binary.Write(buf, binary.BigEndian, int32(key.E)); err != nil { //nolint:gosec
 		return err
 	}
 
diff --git a/wire/net/simple/listener_internal_test.go b/wire/net/simple/listener_internal_test.go
diff --git a/wire/perunio/string.go b/wire/perunio/string.go
diff --git a/wire/protobuf/proposalmsgs.go b/wire/protobuf/proposalmsgs.go
diff --git a/wire/protobuf/serializer.go b/wire/protobuf/serializer.go
diff --git a/wire/protobuf/updatemsgs.go b/wire/protobuf/updatemsgs.go

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func (a *Asset) UnmarshalBinary(data []byte) error {`
`53`	`53`	`if len(data) != assetLen {`
`54`	`54`	`return fmt.Errorf("unexpected length %d, want %d", len(data), assetLen) //nolint:goerr113 // We do not want to define this as constant error.`
`55`	`55`	`}`
`56`		`- a.ID = int64(byteOrder.Uint64(data))`
	`56`	`+ a.ID = int64(byteOrder.Uint64(data)) //nolint:gosec`
`57`	`57`	`return nil`
`58`	`58`	`}`
`59`	`59`
Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ func (a Allocation) Encode(w io.Writer) error {`
`325`	`325`	`err, "invalid allocations cannot be encoded, got %v", a)`
`326`	`326`	`}`
`327`	`327`	`// encode dimensions`
`328`		`- if err := perunio.Encode(w, Index(len(a.Assets)), Index(len(a.Balances[0])), Index(len(a.Locked))); err != nil {`
	`328`	`+ if err := perunio.Encode(w, Index(len(a.Assets)), Index(len(a.Balances[0])), Index(len(a.Locked))); err != nil { //nolint:gosec`
`329`	`329`	`return err`
`330`	`330`	`}`
`331`	`331`	`// encode assets`
`@@ -436,7 +436,7 @@ func (b Balances) Encode(w io.Writer) error {`
`436`	`436`	`return errors.Errorf("expected maximum number of parts %d, got %d", MaxNumParts, numParts)`
`437`	`437`	`}`
`438`	`438`
`439`		`- if err := perunio.Encode(w, Index(numAssets), Index(numParts)); err != nil {`
	`439`	`+ if err := perunio.Encode(w, Index(numAssets), Index(numParts)); err != nil { //nolint:gosec`
`440`	`440`	`return errors.WithMessage(err, "encoding dimensions")`
`441`	`441`	`}`
`442`	`442`	`for i := range b {`
`@@ -667,7 +667,7 @@ func (s SubAlloc) Encode(w io.Writer) error {`
`667`	`667`	`err, "invalid sub-allocations cannot be encoded, got %v", s)`
`668`	`668`	`}`
`669`	`669`	`// encode ID and dimension`
`670`		`- if err := perunio.Encode(w, IDMap(s.ID), Index(len(s.Bals))); err != nil {`
	`670`	`+ if err := perunio.Encode(w, IDMap(s.ID), Index(len(s.Bals))); err != nil { //nolint:gosec`
`671`	`671`	`return errors.WithMessagef(`
`672`	`672`	`err, "encoding sub-allocation ID or dimension, id %v", s.ID)`
`673`	`673`	`}`
`@@ -679,7 +679,7 @@ func (s SubAlloc) Encode(w io.Writer) error {`
`679`	`679`	`}`
`680`	`680`	`}`
`681`	`681`	`// Encode IndexMap.`
`682`		`- if err := perunio.Encode(w, Index(len(s.IndexMap))); err != nil {`
	`682`	`+ if err := perunio.Encode(w, Index(len(s.IndexMap))); err != nil { //nolint:gosec`
`683`	`683`	`return errors.WithMessage(err, "encoding length of index map")`
`684`	`684`	`}`
`685`	`685`	`for i, x := range s.IndexMap {`
Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ func NewRandomChannelID(rng *rand.Rand, opts ...RandomOpt) (id map[wallet.Backen`
`269`	`269`	`for _, b := range bIds {`
`270`	`270`	`cId := [32]byte{}`
`271`	`271`	`rng.Read(cId[:])`
`272`		`- id[wallet.BackendID(b)] = cId`
	`272`	`+ id[b] = cId`
`273`	`273`	`}`
`274`	`274`	`return`
`275`	`275`	`}`
`@@ -281,7 +281,7 @@ func NewRandomChannelID(rng *rand.Rand, opts ...RandomOpt) (id map[wallet.Backen`
`281`	`281`	`} else {`
`282`	`282`	`cId := [32]byte{}`
`283`	`283`	`rng.Read(cId[:])`
`284`		`- id[wallet.BackendID(bId)] = cId`
	`284`	`+ id[bId] = cId`
`285`	`285`	`}`
`286`	`286`	`return`
`287`	`287`	`}`
`@@ -299,7 +299,7 @@ func NewRandomChannelIDs(rng *rand.Rand, n int) (ids []map[wallet.BackendID]chan`
`299`	`299`	`func NewRandomIndexMap(rng *rand.Rand, numParts int, numPartsParent int) (m []channel.Index) {`
`300`	`300`	`m = make([]channel.Index, numParts)`
`301`	`301`	`for i := range m {`
`302`		`- m[i] = channel.Index(rng.Intn(numPartsParent))`
	`302`	`+ m[i] = channel.Index(rng.Intn(numPartsParent)) //nolint:gosec`
`303`	`303`	`}`
`304`	`304`	`return`
`305`	`305`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ func (c *channelConn) Close() error {`
`104`	`104`	`func (c *channelConn) Send(ctx context.Context, msg wire.Msg) error {`
`105`	`105`	`var eg errgroup.Group`
`106`	`106`	`for i, peer := range c.peers {`
`107`		`- if channel.Index(i) == c.idx {`
	`107`	`+ if channel.Index(i) == c.idx { //nolint:gosec`
`108`	`108`	`continue // skip own peer`
`109`	`109`	`}`
`110`	`110`	`c.log.WithField("peer", peer).Debugf("channelConn: publishing message: %v: %+v", msg.Type(), msg)`
`@@ -168,5 +168,5 @@ func (r *channelMsgRecv) Next(ctx context.Context) (channel.Index, ChannelMsg, e`
`168`	`168`	`if !ok {`
`169`	`169`	`return 0, nil, errors.Errorf("unexpected message type: expected ChannelMsg, got %T", env.Msg)`
`170`	`170`	`}`
`171`		`- return channel.Index(idx), msg, nil // predicate must guarantee that the conversion is safe`
	`171`	`+ return channel.Index(idx), msg, nil //nolint:gosec`
`172`	`172`	`}`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ func mkRndChan(rng rand.Rand, bID wallet.BackendID) persistence.Channel {`
`120`	`120`	`parts[i] = map[wallet.BackendID]wallet.Address{bID: wallettest.NewRandomAccount(rng, bID).Address()}`
`121`	`121`	`}`
`122`	`122`	`ch := persistence.NewChannel()`
`123`		`- ch.IdxV = channel.Index(rng.Intn(channel.MaxNumParts))`
	`123`	`+ ch.IdxV = channel.Index(rng.Intn(channel.MaxNumParts)) //nolint:gosec`
`124`	`124`	`ch.ParamsV = test.NewRandomParams(rng, test.WithParts(parts))`
`125`	`125`	`sigs := make([]bool, channel.MaxNumParts)`
`126`	`126`	`opts := test.WithParams(ch.ParamsV)`