Enable multiple policies type #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cendhu
force-pushed
the
integrate-bundle
branch
9 times, most recently
from
67d33d2 to
28bd138
Compare
|
|
||
| message Identity { | ||
| // The identifier of the associated membership service provider | ||
| string msp_id = 1; |
There was a problem hiding this comment.
minor: Is this field necessary? Can't we infer the MSP from the certificate's issuing CA?
There was a problem hiding this comment.
This field is part of Fabric. It is included in the identity. Hence, I have replicated the same here.
service/sidecar/test_exports.go
Outdated
Comment on lines
88
to
89
| Namespaces: validTxNamespaces, | ||
| SignatureSets: make([]*protoblocktx.SignatureSet, 2), // Too many signatures. |
There was a problem hiding this comment.
Why did this PR removes the test case of "Not enough signatures."?
| if v.thresholdVerifier == nil { | ||
| return nil | ||
| } | ||
| digest, err := DigestTxNamespace(txID, tx.Namespaces[nsIndex]) |
There was a problem hiding this comment.
nit: To align all the verifiers, I suggest using ASN1MarshalTxNamespace(txID, tx.Namespaces[nsIndex]) and digesting inside the "thresholdVerifier".
Additionally, our THRESHOLD verifiers can also use protoutil.SignedData{}, where the identity is pre-fixed.
cendhu
force-pushed
the
integrate-bundle
branch
2 times, most recently
from
7a06098 to
c357994
Compare
cendhu
force-pushed
the
integrate-bundle
branch
3 times, most recently
from
c357994 to
3535672
Compare
cendhu
force-pushed
the
integrate-bundle
branch
from
3535672 to
29c6b17
Compare
This commit updates the proto messages to define policy using various rules such as threshold, signature, and hierarchical. Signed-off-by: Senthil Nathan N <cendhu@gmail.com> Signed-off-by: senthil <cendhu@gmail.com>
cendhu
force-pushed
the
integrate-bundle
branch
from
29c6b17 to
4972f6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This commit updates the proto messages to define policy using various rules such as threshold, signature, and hierarchical. Further, it integrates the signature rules with the verifier component.
Related issues