config submitter part 2 #298
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorKatzelnick
force-pushed
the
configSubmitter2
branch
from
08e65db to
4e5dc6c
Compare
config/config.go
Outdated
| } | ||
| func (config *Configuration) ExtractRouterInParty() nodeconfig.RouterInfo { | ||
| partyID := config.LocalConfig.NodeLocalConfig.PartyID | ||
| party := config.SharedConfig.PartiesConfig[partyID-1] |
There was a problem hiding this comment.
We cannot assume that PartiesConfig[partyID-1] corresponds to the correct party.
Instead, you should iterate over PartiesConfig and check if PartiesConfig[i].PartyID == partyID.
config/config.go
Outdated
| func (config *Configuration) ExtractConsenterInParty() nodeconfig.ConsenterInfo { | ||
| partyID := config.LocalConfig.NodeLocalConfig.PartyID | ||
| consenterInfos := config.ExtractConsenters() | ||
| return consenterInfos[partyID-1] |
There was a problem hiding this comment.
Again, loop over consenterInfos to find the correct party
node/consensus/consensus.go
Outdated
|
|
||
| // compare the two certificates | ||
| if !bytes.Equal(pemBlock.Bytes, cert.Raw) { | ||
| return fmt.Errorf("error: access denied; client certificatte is different than the router's certificate") |
There was a problem hiding this comment.
client certificate is different from the router's certificate.
DorKatzelnick
force-pushed
the
configSubmitter2
branch
from
4e5dc6c to
2755521
Compare
HagarMeir
reviewed
Oct 15, 2025
node/consensus/consensus.go
Outdated
| func (sc *Consensus) SubmitConfig(ctx context.Context, request *protos.Request) (*protos.SubmitResponse, error) { | ||
| return nil, fmt.Errorf("SubmitConfig not implemented") | ||
| func (c *Consensus) SubmitConfig(ctx context.Context, request *protos.Request) (*protos.SubmitResponse, error) { | ||
| err := c.validateRouterFromContext(ctx) |
There was a problem hiding this comment.
you can do this in the same line with the if statement
HagarMeir
reviewed
Oct 15, 2025
node/consensus/consensus.go
Outdated
| func (c *Consensus) SubmitConfig(ctx context.Context, request *protos.Request) (*protos.SubmitResponse, error) { | ||
| err := c.validateRouterFromContext(ctx) | ||
| if err != nil { | ||
| return nil, err |
add router info to consenter config router's certificate pinning in SubmitConfig add configSubmitter to router, without forwarding config requests Signed-off-by: Dor.Katzelnick <Dor.Katzelnick@ibm.com>
DorKatzelnick
force-pushed
the
configSubmitter2
branch
from
2755521 to
c0cb710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #192