Skip to content

[Security] Remove sha3 (CVE-2022-37454) #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

[Security] Remove sha3 (CVE-2022-37454) #1679

merged 1 commit into from
Sep 13, 2024

Conversation

PatStLouis
Copy link
Contributor

This package was not critical and features are implemented within hashlib, as pointed out by the package maintainers:
https://github.com/tiran/pysha3

Package is archived.

@PatStLouis
remove sha3
8df8910 
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis requested a review from a team as a code owner September 12, 2024 19:55
WadeBarnes
WadeBarnes requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project does not contain an explicit reference to hashlib as a dependency, one should be added.

@PatStLouis
Copy link
Contributor Author

PatStLouis commented Sep 13, 2024 •
edited
Loading

@WadeBarnes hashlib is part of the python standard library:
https://docs.python.org/3/library/crypto.html

KimEbert42
KimEbert42 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@KimEbert42 KimEbert42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@WadeBarnes WadeBarnes merged commit 8810d2e into hyperledger:main Sep 13, 2024
25 checks passed
@PatStLouis PatStLouis mentioned this pull request Sep 13, 2024
Open
@PatStLouis PatStLouis deleted the replace-sha3-package branch September 13, 2024 18:31
@PatStLouis PatStLouis mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WadeBarnes WadeBarnes WadeBarnes approved these changes

+1 more reviewer

@KimEbert42 KimEbert42 KimEbert42 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatStLouis @KimEbert42 @WadeBarnes