Skip to content

Conversation

GuillaumeBourque-QC
Copy link

Use new apt cli and new herperledger repo

Keep sovrin repo until we dont need it anymore

Run apt update before installing a pkg

Use new apt cli and new herperledger repo

Keep sovrin repo until we dont need it anymore

Run apt update before installing a pkg

Signed-off-by: GuillaumeBourque-QC <guillaume.bourque-ext@mcn.gouv.qc.ca>
swcurran
swcurran previously approved these changes Feb 11, 2025
@swcurran
Copy link
Member

Jumped the gun on approval — didn’t see it was WIP.

Signed-off-by: GuillaumeBourque-QC <guillaume.bourque-ext@mcn.gouv.qc.ca>
Signed-off-by: GuillaumeBourque-QC <guillaume.bourque-ext@mcn.gouv.qc.ca>
@WadeBarnes
Copy link
Member

Looking good.

Put the manual dispatch in the push-manual.yaml new workflow workflow

Remove manual trigger on push.yaml workflow

Tests:
Add tinme wait in the plenum/test/validator_info/test_validator_info.py

Signed-off-by: GuillaumeBourque-QC <guillaume.bourque-ext@mcn.gouv.qc.ca>
Signed-off-by: GuillaumeBourque-QC <guillaume.bourque-ext@mcn.gouv.qc.ca>
@GuillaumeBourque-QC GuillaumeBourque-QC marked this pull request as ready for review February 12, 2025 23:17
@GuillaumeBourque-QC GuillaumeBourque-QC requested a review from a team as a code owner February 12, 2025 23:17
@swcurran swcurran merged commit 708972c into hyperledger:ubuntu-22.04 Feb 13, 2025
25 checks passed
@swcurran
Copy link
Member

w00t!! All the tests passed. I did notice that although the tests passed, there were some errors — e.g. in that last test (7) that I ran a second time, it got a “Resource not accessible by integration” after the test ran. There were a bunch of those that I can you see here. I don’t know if they matter.

What does this mean — are we done??

@swcurran
Copy link
Member

Just realized that this is in the Plenum repo — I thought were done with that 😄 . I know — iteration...

@WadeBarnes
Copy link
Member

w00t!! All the tests passed. I did notice that although the tests passed, there were some errors — e.g. in that last test (7) that I ran a second time, it got a “Resource not accessible by integration” after the test ran. There were a bunch of those that I can you see here. I don’t know if they matter.

It's an issue publishing the reports.

@GuillaumeBourque-QC
Copy link
Author

So we have a base line that is working. The tool still depends on libindy, but we are moving in a better understanding of the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants