Skip to content

feat: Add order grouping support #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JoanLaRosa
Copy link

Add support for order grouping to improve take-profit/stop-loss order visualization on the Hyperliquid website. When orders are grouped, their TP/SL orders will be visually linked together in the UI, making it easier to track related orders.

  • Add optional grouping parameter to Exchange.order() with default value "na"
  • Pass grouping parameter through to bulk_orders()
  • Update order_wires_to_order_action() to include grouping parameter
  • Maintain backwards compatibility by defaulting to "na" grouping

Copy link
Contributor

@traderben traderben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grouping API is pretty confusing so I think if we were to add this it's worth updating basic_tpsl to demonstrate how to use the different groupings

@traderben
Copy link
Contributor

By the way I didn't approve the PR because it's failing lint. I didn't think to post a comment but I realized you might not have received a notification when I approved running the actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants