-
Notifications
You must be signed in to change notification settings - Fork 272
Add WsBbo #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WsBbo #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to support bbo subscriptions you would need to also update websocket_manager to handle the subscription type. Would also be good to update basic_ws.py to include the new subscription
Converting to draft. It doesn't look like the |
The docs are not ahead of the implementation. Subscribing to bbo should work |
You're right, found the issues after turning on debug logging. Thanks for the tip! Pushed fixes + tested locally with basic_ws.py |
@traderben following up here for another review when you get the chance. |
Summary
Adding new WS based on the types from the docs
Test Plan