Skip to content
This repository was archived by the owner on Sep 23, 2025. It is now read-only.

Merge pull request #620 from iKostanOrg/master#621

Merged
ikostan merged 10 commits intomasterfrom
kyu2
Feb 7, 2025
Merged

Merge pull request #620 from iKostanOrg/master#621
ikostan merged 10 commits intomasterfrom
kyu2

Conversation

@ikostan
Copy link
Member

@ikostan ikostan commented Feb 7, 2025

Merge from master

Summary by Sourcery

CI:

  • Add a GitHub Actions workflow to run pytest tests specifically for the kyu_2 directory when changes are pushed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 7, 2025

Reviewer's Guide by Sourcery

The pull request focuses on updating the CI/CD workflow configurations by changing the branch filtering settings from including specific branches to ignoring a broad set of branches. Additionally, a new workflow for running tests on the 'kyu2' branch has been added.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated branch filtering for multiple GitHub workflow configurations.
  • Changed 'push' triggers from specifying branches to using 'branches-ignore' to exclude branches such as main, master, kyu2-kyu8, utils, and Documentation.
  • Applied changes consistently across multiple workflow YAML files to standardize branch filtering.
.github/workflows/mypy.yml
.github/workflows/codacy-coverage-reporter.yaml
.github/workflows/pydocstyle.yml
.github/workflows/codeclimate_coverage.yml
.github/workflows/codecov.yml
.github/workflows/markdown_lint.yml
.github/workflows/codeql.yml
.github/workflows/flake8.yml
.github/workflows/pylint.yml
.github/workflows/pytest.yml
.github/workflows/pytype.yml
.github/workflows/snyk.yml
.github/workflows/yamllint.yml
Added a new GitHub workflow for testing the 'kyu2' branch.
  • Introduced a new workflow file that sets up the environment, installs dependencies, and runs tests using pytest.
  • Configured the new workflow to ignore specific branches, aligning with the updated branch filtering approach in other workflows.
.github/workflows/pytest_kyu2.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • We don't review packaging changes - Let us know if you'd like us to change this.
  • All of the files are larger than we can process. We're working on it!

@ikostan
Copy link
Member Author

ikostan commented Feb 7, 2025

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ikostan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider centralizing the repeated branches-ignore list (e.g., using YAML anchors) to avoid duplication across workflows.
  • Verify that the new pytest_yu2.yml workflow is necessary and not duplicative of the existing pytest workflows.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ikostan ikostan merged commit f226959 into master Feb 7, 2025
15 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant