Merge from master

[ikostan]

Summary by Sourcery

Updates CI configurations for testing and linting. The CircleCI configuration is updated to run tests with pytest and store the results. The GitHub Actions workflows are updated to trigger on push events to the kyu2 branch, and a redundant workflow file is removed.

CI:

• Updates CircleCI configuration to run tests and store results.
• Updates GitHub Actions workflows to trigger on push events to the kyu2 branch.
• Removes the now-unused kyu2.yml workflow.
• Updates the lint_test_build_pipeline.yml workflow to use the pytype_kyu2.yml workflow directly instead of referencing a specific branch.

Tests:

• Configures pytest to generate JUnit XML reports for test results.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 8a3e0731	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (8a3e073)	Report Missing	Report Missing	Report Missing
Head commit (cbce6f1)	2644	2462	93.12%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#667)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the CI workflows for the kyu2 branch to trigger directly on push events instead of using workflow_call. It also updates the lint_test_build_pipeline.yml workflow to directly use the pytype_kyu2.yml workflow and removes the kyu2.yml workflow.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
The CI workflows for kyu2 were updated to trigger directly on push events to the kyu2 branch, instead of using workflow_call.	Removed the workflow_call trigger from mypy_kyu2.yml. Removed the workflow_call trigger from pydocstyle_kyu2.yml. Removed the workflow_call trigger from pylint_kyu2.yml. Removed the workflow_call trigger from flake8_kyu2.yml. Updated the push trigger in mypy_kyu2.yml to only trigger on the kyu2 branch. Updated the push trigger in pydocstyle_kyu2.yml to only trigger on the kyu2 branch. Updated the push trigger in pylint_kyu2.yml to only trigger on the kyu2 branch. Updated the push trigger in flake8_kyu2.yml to only trigger on the kyu2 branch.	.github/workflows/mypy_kyu2.yml .github/workflows/pydocstyle_kyu2.yml .github/workflows/pylint_kyu2.yml .github/workflows/flake8_kyu2.yml
The lint_test_build_pipeline.yml workflow was updated to directly use the pytype_kyu2.yml workflow.	Updated the lint_test_build_pipeline.yml workflow to use the pytype_kyu2.yml workflow directly instead of referencing a specific branch.	.github/workflows/lint_test_build_pipeline.yml
The kyu2.yml workflow was removed.	Removed the kyu2.yml workflow file.	.github/workflows/kyu2.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ikostan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider whether the workflows in kyu_2/ should be consolidated into a single workflow with a matrix strategy.
• It looks like kyu2.yml was deleted - is this intentional?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[qltysh]

❌ 8 blocking issues (8 total)

Tool	Category	Rule	Count
prettier	Style	Incorrect formatting, autoformat by running `qlty fmt`.	8	❌

@qltysh one-click actions:

• Auto-fix formatting (qlty fmt && git push)

[ikostan]

@sourcery-ai review

[sourcery-ai]

Hey @ikostan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using actions/checkout@v3 in your GitHub workflows to ensure you're using the latest version.
• It looks like you're creating the test-results directory with sudo in CircleCI, but you probably don't need to.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}