-
-
Notifications
You must be signed in to change notification settings - Fork 76
[Enhancement] Combobox #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b9d91e4 to
26949c4
Compare
e91eaca to
ad7f95b
Compare
- alignment of comboboxitems. - highlight of focused combobox items.
…per" to "ComboBoxBehaviorHelper"
…sKey instead of hardcoding
NotYoojun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the RestrictToTaskbar attached property in ComboBoxBehaviorHelper was defined but never actually used throughout the codebase. I've removed this unused property to clean up the code.
Verification
I searched the entire codebase and confirmed that:
- No XAML files reference this property
- No C# code calls the getter/setter methods
- The property was only defined but never consumed
@mou-haz Could you clarify the original intention behind this RestrictToTaskbar property? Was this:
- An incomplete feature that was meant to be implemented later?
- A leftover from refactoring that should have been removed?
- Something that was supposed to be used but accidentally missed in the implementation?
If this property was intended to serve a specific purpose, please let me know so we can either:
- Properly implement the missing functionality, or
- Document why it should remain for future use
Otherwise, removing unused code helps maintain a cleaner codebase and reduces confusion for future contributors.
|
@NotYoojun Thanks for the review, As for the winuiCombobox.mp4This is not yet implemented here. so I agree it should be deleted. |
fix #185