Skip to content

Conversation

@mou-haz
Copy link
Contributor

@mou-haz mou-haz commented Jun 28, 2025

fix #185

@mou-haz mou-haz marked this pull request as ready for review July 1, 2025 15:27
@mou-haz mou-haz marked this pull request as draft July 3, 2025 00:02
@mou-haz mou-haz force-pushed the fix_185 branch 2 times, most recently from b9d91e4 to 26949c4 Compare July 10, 2025 23:03
@mou-haz mou-haz marked this pull request as ready for review July 10, 2025 23:45
@mou-haz mou-haz force-pushed the fix_185 branch 2 times, most recently from e91eaca to ad7f95b Compare July 11, 2025 13:42
@mou-haz mou-haz changed the title Fix 185 [Enhancement] Combobox Jul 11, 2025
@mou-haz mou-haz marked this pull request as draft July 14, 2025 17:59
@mou-haz mou-haz marked this pull request as ready for review July 24, 2025 01:48
- alignment of comboboxitems.
- highlight of focused combobox items.
@NotYoojun NotYoojun self-requested a review September 21, 2025 11:56
Copy link
Member

@NotYoojun NotYoojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the RestrictToTaskbar attached property in ComboBoxBehaviorHelper was defined but never actually used throughout the codebase. I've removed this unused property to clean up the code.

Verification

I searched the entire codebase and confirmed that:

  • No XAML files reference this property
  • No C# code calls the getter/setter methods
  • The property was only defined but never consumed

@mou-haz Could you clarify the original intention behind this RestrictToTaskbar property? Was this:

  1. An incomplete feature that was meant to be implemented later?
  2. A leftover from refactoring that should have been removed?
  3. Something that was supposed to be used but accidentally missed in the implementation?

If this property was intended to serve a specific purpose, please let me know so we can either:

  • Properly implement the missing functionality, or
  • Document why it should remain for future use

Otherwise, removing unused code helps maintain a cleaner codebase and reduces confusion for future contributors.

@mou-haz
Copy link
Contributor Author

mou-haz commented Sep 23, 2025

@NotYoojun Thanks for the review, As for the RestrictToTaskbar property, in Winui combobox the popup try to not extend beyond the taskbar but rather shift upwards.

winuiCombobox.mp4

This is not yet implemented here. so I agree it should be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match the style of ComboBox up with WinUI 3

2 participants