Skip to content

Commit 1086345

Browse files
committed
fix: OBB comment
1 parent e8faa94 commit 1086345

File tree

1 file changed

+2
-2
lines changed
  • packages/Main/src/Renderer

1 file changed

+2
-2
lines changed

packages/Main/src/Renderer/OBB.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ const coord = new Coordinates('EPSG:4326', 0, 0, 0);
1414
let _obb: OBB;
1515

1616
// it could be considered to remove THREE.Object3D extend.
17-
// we should investigate the use of the THREE.OBB class.
1817
/**
1918
* Represents an oriented bounding box.
2019
*/
@@ -70,6 +69,8 @@ class OBB extends THREE.Object3D {
7069

7170
// TODO: why not add the geoid height to the min and max parameters?
7271
// The implementation of GeoidLayer is leaking here.
72+
// This will be fixed when geoid layers will be considered as elevation
73+
// layers.
7374
const geoidHeight = elevation.geoidHeight || 0;
7475

7576
this.box3D.min.z = this.natBox.min.z + this.z.min * this.z.scale + geoidHeight;
@@ -107,7 +108,6 @@ class OBB extends THREE.Object3D {
107108
* @returns return this object
108109
*/
109110
setFromExtent(extent: Extent, minHeight = 0, maxHeight = 0): this {
110-
// TODO: The crs are hardcoded here.
111111
if (extent.crs == 'EPSG:4326') {
112112
const {
113113
shareableExtent,

0 commit comments

Comments
 (0)