IBX-9060: Specified iterable value types and generic return types to satisfy PHPStan

Author: tbialcz

src/bundle/Form/Data/SearchQueryData.php

@@ -12,17 +12,24 @@
 
 final class SearchQueryData
 {
+    /** @var string[] */
     private array $statuses = [];
 
     private ?string $type = null;
 
     private ?DateRangeData $createdRange = null;
 
+    /**
+     * @return string[]
+     */
     public function getStatuses(): array
     {
         return $this->statuses;
     }
 
+    /**
+     * @param string[] $statuses
+     */
     public function setStatuses(array $statuses): void
     {
         $this->statuses = $statuses;

src/bundle/Form/Type/SearchType.php

@@ -15,6 +15,9 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @extends AbstractType<SearchQueryData>
+ */
 final class SearchType extends AbstractType
 {
     public function buildForm(FormBuilderInterface $builder, array $options): void

src/lib/Form/Data/Notification/NotificationSelectionData.php

@@ -10,18 +10,28 @@
 
 class NotificationSelectionData
 {
+    /** @var \Ibexa\Contracts\Core\Repository\Values\Notification\Notification[] */
     private array $notifications;
 
+    /**
+     * @param \Ibexa\Contracts\Core\Repository\Values\Notification\Notification[] $notifications
+     */
     public function __construct(array $notifications = [])
     {
         $this->notifications = $notifications;
     }
 
+    /**
+     * @return \Ibexa\Contracts\Core\Repository\Values\Notification\Notification[]
+     */
     public function getNotifications(): array
     {
         return $this->notifications;
     }
 
+    /**
+     * @param \Ibexa\Contracts\Core\Repository\Values\Notification\Notification[] $notifications
+     */
     public function setNotifications(array $notifications): void
     {
         $this->notifications = $notifications;

src/lib/Form/Factory/FormFactory.php

@@ -1070,7 +1070,7 @@ public function removeContentDraft(
      * @param \Ibexa\AdminUi\Form\Data\Notification\NotificationSelectionData|null $data
      * @param string|null $name
      *
-     * @return \Symfony\Component\Form\FormInterface
+     * @return \Symfony\Component\Form\FormInterface<\Ibexa\AdminUi\Form\Data\Notification\NotificationSelectionData|null>
      */
     public function deleteNotification(
         NotificationSelectionData $data = null,
@@ -1141,7 +1141,7 @@ public function deleteURLWildcard(
         ?URLWildcardDeleteData $data = null,
         ?string $name = null
     ): FormInterface {
-        $name = $name ?: StringUtil::fqcnToBlockPrefix(URLWildcardDeleteType::class);
+        $name = (string)($name ?: StringUtil::fqcnToBlockPrefix(URLWildcardDeleteType::class));
 
         return $this->formFactory->createNamed(
             $name,

src/lib/Form/Type/Notification/NotificationSelectionType.php

@@ -16,6 +16,9 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * @extends AbstractType<NotificationSelectionData>
+ */
 class NotificationSelectionType extends AbstractType
 {
     public function buildForm(FormBuilderInterface $builder, array $options): void