Review fixes pt 3

Author: albozek

src/bundle/Resources/public/js/scripts/admin.notifications.list.js

@@ -4,7 +4,7 @@
     const SELECTOR_TOGGLE_NOTIFICATION = '.ibexa-notification-view-all__mail';
     const { showErrorNotification } = ibexa.helpers.notification;
     const { getJsonFromResponse } = ibexa.helpers.request;
-    const markAllAsReadBtn = doc.querySelector('.ibexa-notification-list__mark-all-read');
+    const markAllAsReadBtn = doc.querySelector('.ibexa-notification-list__btn--mark-all-as-read');
     const markAsReadBtn = doc.querySelector('.ibexa-notification-list__btn--mark-as-read');
     const deleteBtn = doc.querySelector('.ibexa-notification-list__btn--delete');
     const notificationsCheckboxes = [

src/bundle/Resources/public/scss/_notifications.scss

@@ -73,7 +73,7 @@
         border-radius: 0 $ibexa-border-radius $ibexa-border-radius 0;
         border: calculateRem(1px) solid $ibexa-color-light;
         background-color: $ibexa-color-white;
-        transition: width 0.3s ease;
+        transition: width $ibexa-admin-transition-duration $ibexa-admin-transition;
     }
 
     &__table-btns {

src/bundle/Resources/public/scss/_side-panel.scss

@@ -2,7 +2,7 @@
     background-color: $ibexa-color-white;
     padding: calculateRem(8px) 0;
     width: calculateRem(516px);
-    height: calc(100vh - #{calculateRem(73px)});
+    height: calc(100vh - calculateRem(73px));
     position: fixed;
     top: calculateRem(73px);
     right: 0;

src/bundle/Resources/views/themes/admin/account/notifications/filters.html.twig

@@ -44,7 +44,9 @@
 
     <div class="ibexa-list-filters__items accordion">
         {{ form_row(search_form.type) }}
-        {% if search_form.statuses is defined %}{{ form_row(search_form.statuses) }}{% endif %}
+        {% if search_form.statuses is defined %}
+            {{ form_row(search_form.statuses) }}
+        {% endif %}
         {{ form_row(search_form.createdRange) }}
         {{ form_rest(search_form) }}
     </div>

src/bundle/Resources/views/themes/admin/account/notifications/list_all.html.twig

@@ -1,4 +1,4 @@
-{% extends "@ibexadesign/ui/layout.html.twig" %}
+{% extends '@ibexadesign/ui/layout.html.twig' %}
 
 {% import '@ibexadesign/ui/component/macros.html.twig' as html %}
 {% import _self as macros %}
@@ -12,7 +12,7 @@
 {% block title %}{{ 'ibexa_notifications'|trans|desc('Notifications') }}{% endblock %}
 
 {% block header %}
-    <div class="ibexa-notification-list__mark-all-read">
+    <div class="ibexa-notification-list__btn--mark-all-as-read">
         <button class="btn ibexa-btn ibexa-btn--secondary">
             {{ 'ibexa_notifications.btn.mark_all_as_read'|trans|desc('Mark all as read') }}
         </button>
@@ -25,7 +25,7 @@
 
 {% block content %}
     {{ form_start(form_remove, {
-        'action': path('ibexa.notifications.delete_multiple'),
+        action: path('ibexa.notifications.delete_multiple'),
         'attr': {
             'class': 'ibexa-toggle-btn-state ibexa-notification-list__hidden-btn',
             'data-toggle-button-id': '#confirm-' ~ form_remove.remove.vars.id

src/bundle/Resources/views/themes/admin/ui/component/side_panel/side_panel.html.twig

@@ -6,9 +6,8 @@
 {% set config_panel_footer_class = 'ibexa-side-panel__footer' ~ (footer_class is defined ? footer_class ~ '')%}
 
 {% set attr = attr|default({})|merge({
-    class: (' '
-        ~ class|default('') ~ ' '
-        ~ attr.class|default(''))|trim ~ ' ' ~ config_panel_main_class,
+        ~ attr.class|default(''))|trim ~ ' '
+        ~ config_panel_main_class,
 }) %}
 
 {% if id is defined %}