Skip to content

IBX-8638: Ensured last ancestor is valid before comparing paths in TrashItemData #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

wiewiurdp
Copy link
Contributor

🎫 Issue IBX-8638

Description:

Ensured last ancestor is valid before comparing paths in TrashItemData

For QA:

Check if after removing folder which is root in tree via API, we can open trash without problems

@wiewiurdp wiewiurdp requested a review from a team June 16, 2025 13:51
@ezrobot ezrobot requested review from adamwojs, mikadamczyk, Steveb-p, alongosz, ciastektk, ViniTou and barw4 and removed request for a team June 16, 2025 13:52
@wiewiurdp wiewiurdp marked this pull request as ready for review June 16, 2025 13:52
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to cover that change with some tests?

@adamwojs
Copy link
Member

Is there any way to cover that change with some tests?

@wiewiurdp It's good idea 😉

Copy link

@wiewiurdp wiewiurdp closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants