Skip to content

[TMP] IBX-10170: Refactored access check to use new contract interface #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dependencies.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"recipesEndpoint": "",
"packages": [
{
"requirement": "dev-ibx-10170-access-check as 5.0.x-dev",
"repositoryUrl": "https://github.com/ibexa/user",
"package": "ibexa/user",
"shouldBeAddedAsVCS": false
}
]
}
34 changes: 0 additions & 34 deletions src/bundle/EventSubscriber/PerformAccessCheckSubscriber.php

This file was deleted.

4 changes: 0 additions & 4 deletions src/bundle/Resources/config/services/events.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ services:
tags:
- { name: kernel.event_subscriber }

Ibexa\Bundle\AdminUi\EventSubscriber\PerformAccessCheckSubscriber:
tags:
- { name: kernel.event_subscriber }

Ibexa\AdminUi\EventListener\RequestListener:
arguments:
- '%ibexa.site_access.groups_by_site_access%'
Expand Down
9 changes: 4 additions & 5 deletions src/contracts/Controller/Controller.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@
namespace Ibexa\Contracts\AdminUi\Controller;

use Ibexa\Contracts\Core\Repository\Values\Content\Location;
use Ibexa\Contracts\User\Controller\AuthenticatedRememberedCheckTrait;
use Ibexa\Contracts\User\Controller\RestrictedControllerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\RedirectResponse;

abstract class Controller extends AbstractController
abstract class Controller extends AbstractController implements RestrictedControllerInterface

Check failure on line 17 in src/contracts/Controller/Controller.php

View workflow job for this annotation

GitHub Actions / Tests (8.3)

Class Ibexa\Contracts\AdminUi\Controller\Controller implements unknown interface Ibexa\Contracts\User\Controller\RestrictedControllerInterface.
{
public function performAccessCheck(): void
{
$this->denyAccessUnlessGranted('IS_AUTHENTICATED_REMEMBERED');
}
use AuthenticatedRememberedCheckTrait;

Check failure on line 19 in src/contracts/Controller/Controller.php

View workflow job for this annotation

GitHub Actions / Tests (8.3)

Class Ibexa\Contracts\AdminUi\Controller\Controller uses unknown trait Ibexa\Contracts\User\Controller\AuthenticatedRememberedCheckTrait.

public function redirectToLocation(Location $location, string $uriFragment = ''): RedirectResponse
{
Expand Down
Loading