Skip to content

Conversation

@Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Nov 20, 2024

🎫 Issue IBX-XXXXX

Description:

This PR aims to fix an issue where specific types representing database values - namely, DateTimeInterface in context of Doctrine DBAL date & time types - are not working properly.

This allows for example:

$gateway->findBy(['date' => new DateTimeImmutable('2025-01-01 00:00:00']),

as well as using Comparison operators with date time objects, without formatting them explicitly in the gateway/handler.

use Doctrine\Common\Collections\Expr\Comparison

$gateway->findBy([new Comparison('field', '>', new DateTimeImmutable('2025-01-01 00:00:00'))]),

Reported deprecations are due to Doctrine internal calls, which we are mocking during tests.

For QA:

Documentation:

@adamwojs adamwojs force-pushed the fix-date-time-find-by branch from 9f48398 to 2c48633 Compare February 2, 2025 11:47
@Steveb-p Steveb-p marked this pull request as ready for review February 11, 2025 12:17
@Steveb-p Steveb-p requested a review from a team February 11, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants