Skip to content

Conversation

@Adil9645
Copy link

Signed-off-by: A S Adil Mohammad asadilmohammad2020@gmail.com

Description

This pull request fixes the issue of exception when setting mq.ssl.use.ibm.cipher.mappings.In source code, the configuration CONFIG_NAME_MQ_SSL_USE_IBM_CIPHER_MAPPINGS is defined as Type.BOOLEAN but it was being used as: config.getString(MQSinkConfig.CONFIG_NAME_MQ_SSL_USE_IBM_CIPHER_MAPPINGS)

Fixes #73

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Integration Test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: A S Adil Mohammad <asadilmohammad2020@gmail.com>
A S Adil Mohammad added 2 commits July 21, 2025 16:06
Signed-off-by: A S Adil Mohammad <asadilmohammad2020@gmail.com>
Signed-off-by: A S Adil Mohammad <asadilmohammad2020@gmail.com>
@Adil9645 Adil9645 requested a review from Joel-hanson July 22, 2025 06:30
Copy link
Contributor

@Joel-hanson Joel-hanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: A S Adil Mohammad <asadilmohammad2020@gmail.com>
@Joel-hanson Joel-hanson merged commit 4ed7f64 into ibm-messaging:main Jul 23, 2025
2 checks passed
Joel-hanson pushed a commit that referenced this pull request Jul 23, 2025
- Fixes the issue of exception when setting mq.ssl.use.ibm.cipher.mappings.
- In source code, the configuration CONFIG_NAME_MQ_SSL_USE_IBM_CIPHER_MAPPINGS
  is defined as Type.BOOLEAN but it was being used as:
  config.getString(MQSinkConfig.CONFIG_NAME_MQ_SSL_USE_IBM_CIPHER_MAPPINGS)

Signed-off-by: A S Adil Mohammad <asadilmohammad2020@gmail.com>
Signed-off-by: Joel Hanson <joelhanson025@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Got exception when setting mq.ssl.use.ibm.cipher.mappings for mq sink connector

2 participants