Skip to content

fixing exception when setting mq.ssl.use.ibm.cipher.mappings for mq sink connector #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2025
Merged

fixing exception when setting mq.ssl.use.ibm.cipher.mappings for mq sink connector #74

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b091b89
fix: incorrect datatype in config
Jul 18, 2025
8dfef64
fixing the test
Jul 21, 2025
c49b06c
Adding a failure case for the test
Jul 22, 2025
287ff7b
Removing unwanted lines and spaces
Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/integration/java/com/ibm/eventstreams/connect/mqsink/MQSinkTaskIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,42 @@ public void verifyStringMessages() throws JMSException {
assertEquals("world", messagesInMQ.get(1).getBody(String.class));
}

@Test
public void verifyCipherMappingsConfig() throws JMSException {
final MQSinkTask newConnectTask = new MQSinkTask();

// configure a sink task for validating config
final Map<String, String> connectorConfigProps = createDefaultConnectorProperties();
connectorConfigProps.put("mq.message.builder",
DEFAULT_MESSAGE_BUILDER);

connectorConfigProps.put("mq.ssl.use.ibm.cipher.mappings",
"true");

// start the task so that it connects to MQ
newConnectTask.start(connectorConfigProps);

// Check if the config reflects the change
String cipherMappingProp = System.getProperty("com.ibm.mq.cfg.useIBMCipherMappings");
assertEquals("true", cipherMappingProp);

// stop the task
newConnectTask.stop();

// configure a sink task for validating config for failure case
connectorConfigProps.put("mq.message.builder",
DEFAULT_MESSAGE_BUILDER);

connectorConfigProps.put("mq.ssl.use.ibm.cipher.mappings",
"hello");

// Verify the exception messages
final ConfigException exc = assertThrows(ConfigException.class, () -> {
newConnectTask.start(connectorConfigProps);
});
assertEquals("Invalid value hello for configuration mq.ssl.use.ibm.cipher.mappings: Expected value to be either true or false", exc.getMessage());
}

@Test
public void verifyStringJmsMessages() throws JMSException {
final MQSinkTask newConnectTask = new MQSinkTask();
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/ibm/eventstreams/connect/mqsink/JMSWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void configure(final AbstractConfig config) throws ConnectException {
mqConnectionHelper = new MQConnectionHelper(config);

if (mqConnectionHelper.getUseIBMCipherMappings() != null) {
System.setProperty("com.ibm.mq.cfg.useIBMCipherMappings", mqConnectionHelper.getUseIBMCipherMappings());
System.setProperty("com.ibm.mq.cfg.useIBMCipherMappings", Boolean.toString(mqConnectionHelper.getUseIBMCipherMappings()));
}

try {
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/ibm/eventstreams/connect/mqsink/MQConnectionHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ public Boolean isPersistent() {
return config.getBoolean(MQSinkConfig.CONFIG_NAME_MQ_PERSISTENT);
}

public String getUseIBMCipherMappings() {
return config.getString(MQSinkConfig.CONFIG_NAME_MQ_SSL_USE_IBM_CIPHER_MAPPINGS);
public Boolean getUseIBMCipherMappings() {
return config.getBoolean(MQSinkConfig.CONFIG_NAME_MQ_SSL_USE_IBM_CIPHER_MAPPINGS);
}

public int getTransportType() {
Expand Down