Should ICAT quit if it doesn't recognise the application server?

[stuartpullinger]

Because the code to recognise the application server (container type) fails when run in Payara's provided docker image (see icatproject/icat.utils#15), icat.server stopped rather than continue in an unknown application server. Is this really the behaviour we want? Given that there a many different application servers, should it really require a change to the code to try icat.server on a previously unknown application server? Perhaps this line should be changed to just log a WARNING that the current application server is not recognised and, therefore, may be unstable?

What does @ajkyffin think?

[ajkyffin]

I think the only place that the containerType gets used is the /properties REST endpoint:

icat.server/src/main/java/org/icatproject/exposed/ICATRest.java

Line 477 in f86b255

.add("authenticators", authenticatorArrayBuilder).add("containerType", containerType.name());

so there is no need to quit if it is unknown. I don't think a warning is necessary either.