Skip to content

Conversation

@XGHeaven
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates TypeScript from version ^4.9.4 to ^5.0.0 and enables strict compiler options to improve type safety across the codebase.

  • Updates TypeScript version in workspace catalog and package.json files
  • Fixes type errors by adding explicit type annotations, null checks, and type guards
  • Replaces any types with more specific types like unknown or proper interfaces

Reviewed Changes

Copilot reviewed 39 out of 42 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Updates TypeScript version from ^4.9.4 to ^5.0.0
packages/pkg/src/utils.ts Adds strict type annotations, null safety, and replaces any with unknown
packages/pkg/src/types.ts Updates type definitions to use unknown instead of any
packages/pkg/src/test/defineJestConfig.ts Adds explicit type annotation for moduleNameMapper
packages/pkg/src/tasks/transform.ts Extensive type safety improvements and null checks
packages/pkg/src/tasks/declaration.worker.ts Adds non-null assertion for parentPort
packages/pkg/src/tasks/declaration.ts Adds null coalescing and type safety
packages/pkg/src/tasks/bundle.ts Major type safety improvements for rollup integration
packages/pkg/src/rollupPlugins/swc.ts Improves parameter type safety
packages/pkg/src/rollupPlugins/babel.ts Fixes return value handling
packages/pkg/src/rollupPlugins/alias.ts Adds null checks and type safety
Multiple helper files Various type safety improvements and strict mode compatibility
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/pkg/src/tasks/bundle.ts:1

  • The as any type assertion bypasses TypeScript's type checking. Consider defining proper types for the RPC call parameters to maintain type safety.
import * as path from 'path';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 29, 2025

More templates

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/create-pkg@696
npm i https://pkg.pr.new/ice-lab/icepkg/ice-npm-utils@696
npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg@696
npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg-plugin-jsx-plus@696

commit: 1bb11a3

@XGHeaven XGHeaven force-pushed the feat/upgrade-tsc branch 2 times, most recently from b0f9870 to bc52b44 Compare September 29, 2025 09:53
@XGHeaven XGHeaven requested a review from Copilot September 29, 2025 09:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 39 out of 42 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@XGHeaven XGHeaven merged commit bd2d88d into next Sep 30, 2025
5 checks passed
@XGHeaven XGHeaven deleted the feat/upgrade-tsc branch September 30, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants