-
Notifications
You must be signed in to change notification settings - Fork 75
feat: update typescript version and enable strict compiler option #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8bd8b9a to
b1e59d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates TypeScript from version ^4.9.4 to ^5.0.0 and enables strict compiler options to improve type safety across the codebase.
- Updates TypeScript version in workspace catalog and package.json files
- Fixes type errors by adding explicit type annotations, null checks, and type guards
- Replaces
anytypes with more specific types likeunknownor proper interfaces
Reviewed Changes
Copilot reviewed 39 out of 42 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates TypeScript version from ^4.9.4 to ^5.0.0 |
| packages/pkg/src/utils.ts | Adds strict type annotations, null safety, and replaces any with unknown |
| packages/pkg/src/types.ts | Updates type definitions to use unknown instead of any |
| packages/pkg/src/test/defineJestConfig.ts | Adds explicit type annotation for moduleNameMapper |
| packages/pkg/src/tasks/transform.ts | Extensive type safety improvements and null checks |
| packages/pkg/src/tasks/declaration.worker.ts | Adds non-null assertion for parentPort |
| packages/pkg/src/tasks/declaration.ts | Adds null coalescing and type safety |
| packages/pkg/src/tasks/bundle.ts | Major type safety improvements for rollup integration |
| packages/pkg/src/rollupPlugins/swc.ts | Improves parameter type safety |
| packages/pkg/src/rollupPlugins/babel.ts | Fixes return value handling |
| packages/pkg/src/rollupPlugins/alias.ts | Adds null checks and type safety |
| Multiple helper files | Various type safety improvements and strict mode compatibility |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/pkg/src/tasks/bundle.ts:1
- The
as anytype assertion bypasses TypeScript's type checking. Consider defining proper types for the RPC call parameters to maintain type safety.
import * as path from 'path';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b1e59d5 to
b3f5eb6
Compare
More templates
commit: |
b0f9870 to
bc52b44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 39 out of 42 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bc52b44 to
76bc74c
Compare
76bc74c to
1bb11a3
Compare
No description provided.